Introduce a post start command

Having a post start command makes it easier to run several
commands at once after debugging starts, thus avoiding
any race conditions between commands.

See comments on #116 for examples.

Author: robertbasic

pugdebug/debugger.py

@@ -29,6 +29,7 @@ class PugdebugDebugger(QObject):
     current_line = 0
 
     debugging_started_signal = pyqtSignal()
+    debugging_post_start_signal = pyqtSignal()
     debugging_stopped_signal = pyqtSignal()
     step_command_signal = pyqtSignal()
     got_all_variables_signal = pyqtSignal(object)
@@ -78,6 +79,9 @@ def connect_connection_signals(self, connection):
         """
 
         # Stop/detach signals
+        connection.post_start_signal.connect(
+            self.handle_post_start
+        )
         connection.stopped_signal.connect(
             self.handle_stopped
         )
@@ -194,6 +198,12 @@ def start_new_connection(self):
 
         self.debugging_started_signal.emit()
 
+    def post_start_command(self, post_start_data):
+        self.current_connection.post_start_command(post_start_data)
+
+    def handle_post_start(self):
+        self.debugging_post_start_signal.emit()
+
     def handle_server_stopped(self):
         if not self.is_connected():
             self.cleanup()

pugdebug/pugdebug.py

@@ -169,6 +169,9 @@ def connect_debugger_signals(self):
         self.debugger.debugging_started_signal.connect(
             self.handle_debugging_started
         )
+        self.debugger.debugging_post_start_signal.connect(
+            self.handle_debugging_post_start
+        )
         self.debugger.debugging_stopped_signal.connect(
             self.handle_debugging_stopped
         )
@@ -454,9 +457,21 @@ def handle_debugging_started(self):
 
         self.main_window.toggle_actions(True)
 
-        self.set_init_breakpoints(self.init_breakpoints)
+        post_start_data = {
+            'init_breakpoints': self.init_breakpoints
+        }
+        self.debugger.post_start_command(post_start_data)
+
+    def handle_debugging_post_start(self):
+        """Handle post start debugging
 
-        self.open_document(self.debugger.get_index_file())
+        If the code should not break at first line, run the debugger.
+        """
+        break_at_first_line = int(get_setting('debugger/break_at_first_line'))
+        if break_at_first_line == 0:
+            self.run_debug()
+        else:
+            self.step_into()
 
     def stop_debug(self):
         """Stop a debugging session

pugdebug/server.py

@@ -107,6 +107,7 @@ class PugdebugServerConnection(QThread):
 
     xdebug_encoding = 'iso-8859-1'
 
+    post_start_signal = pyqtSignal()
     stopped_signal = pyqtSignal()
     detached_signal = pyqtSignal()
     stepped_signal = pyqtSignal(dict)
@@ -182,7 +183,14 @@ def run(self):
         action = self.action
 
         try:
-            if action == 'stop':
+            if action == 'post_start':
+                response = self.__post_start(data)
+
+                self.listed_breakpoints_signal.emit(
+                    response['breakpoints']
+                )
+                self.post_start_signal.emit()
+            elif action == 'stop':
                 response = self.__stop()
                 self.stopped_signal.emit()
             elif action == 'detach':
@@ -234,6 +242,11 @@ def disconnect(self):
         if self.socket is not None:
             self.socket.close()
 
+    def post_start_command(self, post_start_data):
+        self.data = post_start_data
+        self.action = 'post_start'
+        self.start()
+
     def stop(self):
         self.action = 'stop'
         self.start()
@@ -287,6 +300,16 @@ def evaluate_expression(self, index, expression):
         self.data = (index, expression)
         self.start()
 
+    def __post_start(self, data):
+        post_start_response = {
+            'init_breakpoints': self.__set_init_breakpoints(
+                data['init_breakpoints']
+            ),
+            'breakpoints': self.__list_breakpoints()
+        }
+
+        return post_start_response
+
     def __stop(self):
         command = 'stop -i %d' % self.__get_transaction_id()
         self.__send_command(command)