return early if new connection is not valid

Author: robertbasic

pugdebug/server.py

@@ -66,9 +66,9 @@ def __connect(self):
 
                     if sock is not None:
                         connection = PugdebugServerConnection(sock)
-                        connection.init_connection()
+                        is_valid = connection.init_connection()
 
-                        if connection.is_valid:
+                        if is_valid:
                             self.server_connected_signal.emit(connection)
                 except socket.timeout:
                     pass
@@ -134,7 +134,7 @@ def init_connection(self):
 
         # See if the init message from xdebug is meant for us
         if idekey != '' and init_message['idekey'] != idekey:
-            self.is_valid = False
+            return False
 
         command = 'feature_set -i %d -n max_depth -v 9' % (
             self.__get_transaction_id()
@@ -151,9 +151,10 @@ def init_connection(self):
         )
         response = self.__send_command(command)
 
-        self.is_valid = True
         self.init_message = init_message
 
+        return True
+
     def run(self):
         self.mutex.lock()