Merge pull request #96 from robertbasic/feature/debugger-features-from-settings

Feature/debugger features from settings. Resolves #95

Author: robertbasic

pugdebug/gui/settings.py

@@ -70,6 +70,29 @@ def __init__(self, parent):
         break_at_first_line = int(get_setting('debugger/break_at_first_line'))
         self.break_at_first_line.setCheckState(break_at_first_line)
 
+        self.max_depth = QLineEdit()
+
+        self.max_depth.editingFinished.connect(self.handle_max_depth_changed)
+
+        max_depth = get_setting('debugger/max_depth')
+        self.max_depth.setText(max_depth)
+
+        self.max_children = QLineEdit()
+
+        self.max_children.editingFinished.connect(
+            self.handle_max_children_changed
+        )
+
+        max_children = get_setting('debugger/max_children')
+        self.max_children.setText(max_children)
+
+        self.max_data = QLineEdit()
+
+        self.max_data.editingFinished.connect(self.handle_max_data_changed)
+
+        max_data = get_setting('debugger/max_data')
+        self.max_data.setText(max_data)
+
         layout = QFormLayout()
         self.setLayout(layout)
 
@@ -79,6 +102,9 @@ def __init__(self, parent):
         layout.addRow("Port", self.port_number)
         layout.addRow("IDE Key", self.idekey)
         layout.addRow("", self.break_at_first_line)
+        layout.addRow("Max depth", self.max_depth)
+        layout.addRow("Max children", self.max_children)
+        layout.addRow("Max data", self.max_data)
 
     def get_project_root(self):
         return self.project_root.text()
@@ -116,3 +142,15 @@ def handle_idekey_changed(self):
 
     def handle_break_at_first_line_changed(self, value):
         set_setting('debugger/break_at_first_line', value)
+
+    def handle_max_depth_changed(self):
+        value = self.max_depth.text()
+        set_setting('debugger/max_depth', value)
+
+    def handle_max_children_changed(self):
+        value = self.max_children.text()
+        set_setting('debugger/max_children', value)
+
+    def handle_max_data_changed(self):
+        value = self.max_data.text()
+        set_setting('debugger/max_data', value)

pugdebug/models/settings.py

@@ -56,6 +56,15 @@ def setup_debugger_settings(self):
             # between checked and unchecked state
             self.application_settings.setValue('break_at_first_line', 2)
 
+        if not self.application_settings.contains('max_depth'):
+            self.application_settings.setValue('max_depth', '3')
+
+        if not self.application_settings.contains('max_children'):
+            self.application_settings.setValue('max_children', '128')
+
+        if not self.application_settings.contains('max_data'):
+            self.application_settings.setValue('max_data', '512')
+
         self.application_settings.endGroup()
 
     def setup_path_settings(self):

pugdebug/server.py

@@ -148,18 +148,24 @@ def init_connection(self):
         if idekey != '' and init_message['idekey'] != idekey:
             return False
 
-        command = 'feature_set -i %d -n max_depth -v 9' % (
-            self.__get_transaction_id()
+        max_depth = int(get_setting('debugger/max_depth'))
+        command = 'feature_set -i %d -n max_depth -v %d' % (
+            self.__get_transaction_id(),
+            max_depth
         )
         response = self.__send_command(command)
 
-        command = 'feature_set -i %d -n max_children -v 512' % (
-            self.__get_transaction_id()
+        max_children = int(get_setting('debugger/max_children'))
+        command = 'feature_set -i %d -n max_children -v %d' % (
+            self.__get_transaction_id(),
+            max_children
         )
         response = self.__send_command(command)
 
-        command = 'feature_set -i %d -n max_data -v 4096' % (
-            self.__get_transaction_id()
+        max_data = int(get_setting('debugger/max_data'))
+        command = 'feature_set -i %d -n max_data -v %d' % (
+            self.__get_transaction_id(),
+            max_data
         )
         response = self.__send_command(command)