Skip to content
This repository was archived by the owner on Aug 28, 2020. It is now read-only.

Commit 8137231

Browse files
committed
Show settings in a modal window instead of dock
This makes more sense since settings do not need to be visible all the time.
1 parent 733155f commit 8137231

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

pugdebug/gui/main_window.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,6 @@ def setup_docks(self):
8585
Qt.LeftDockWidgetArea
8686
)
8787

88-
self.__add_dock_widget(
89-
self.settings_window,
90-
"Settings",
91-
Qt.LeftDockWidgetArea
92-
)
93-
9488
self.__add_dock_widget(
9589
self.variable_viewer,
9690
"Variables",
@@ -179,6 +173,11 @@ def setup_actions(self):
179173
self.quit_action.setShortcut(QKeySequence("Alt+F4"))
180174
self.quit_action.triggered.connect(self.close)
181175

176+
self.show_settings_action = QAction("&Settings", self)
177+
self.show_settings_action.setToolTip("Show settings")
178+
self.show_settings_action.setStatusTip("Show the settings window.")
179+
self.show_settings_action.triggered.connect(self.settings_window.exec)
180+
182181
def setup_toolbar(self):
183182
toolbar = QToolBar("Main Toolbar")
184183
toolbar.setObjectName("main-toolbar")
@@ -199,6 +198,7 @@ def setup_menubar(self):
199198

200199
file_menu = menu_bar.addMenu("&File")
201200
file_menu.addAction(self.quit_action)
201+
file_menu.addAction(self.show_settings_action)
202202

203203
view_menu = menu_bar.addMenu("&View")
204204

pugdebug/gui/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99

1010
__author__ = "robertbasic"
1111

12-
from PyQt5.QtWidgets import (QWidget, QLineEdit, QFormLayout,
12+
from PyQt5.QtWidgets import (QDialog, QLineEdit, QFormLayout,
1313
QSpinBox, QCheckBox)
1414

1515
from pugdebug.models.settings import get_setting, set_setting
1616

1717

18-
class PugdebugSettingsWindow(QWidget):
18+
class PugdebugSettingsWindow(QDialog):
1919

2020
layout = QFormLayout()
2121

0 commit comments

Comments
 (0)