Merge pull request #123 from robertbasic/feature/update-debugger-features-while-debugging-in-progress

Feature/update debugger features while debugging in progress. Resolves #103

Author: robertbasic

pugdebug/debugger.py

@@ -322,6 +322,9 @@ def handle_expressions_evaluated(self, results):
         """Handle when server evaluates a list of expressions"""
         self.expressions_evaluated_signal.emit(results)
 
+    def set_debugger_features(self):
+        self.current_connection.set_debugger_features()
+
     def handle_server_error(self, error):
         """Handle when an error occurs in the server
         """

pugdebug/pugdebug.py

@@ -414,6 +414,13 @@ def handle_settings_changed(self, changed_settings):
         if 'path/project_root' in changed_settings:
             self.handle_project_root_changed()
 
+        features = ['debugger/max_depth',
+                    'debugger/max_children',
+                    'debugger/max_data']
+
+        if any(True for feature in features if feature in changed_settings):
+            self.handle_debugger_features_changed()
+
     def handle_project_root_changed(self):
         """Handle when the project root is changed
 
@@ -426,6 +433,10 @@ def handle_project_root_changed(self):
         self.file_browser.setModel(model)
         self.file_browser.setRootIndex(model.start_index)
 
+    def handle_debugger_features_changed(self):
+        if self.debugger.is_connected():
+            self.debugger.set_debugger_features()
+
     def start_debug(self):
         """Start a new debugging session
 

pugdebug/server.py

@@ -150,26 +150,7 @@ def init_connection(self):
         if idekey != '' and init_message['idekey'] != idekey:
             return False
 
-        max_depth = int(get_setting('debugger/max_depth'))
-        command = 'feature_set -i %d -n max_depth -v %d' % (
-            self.__get_transaction_id(),
-            max_depth
-        )
-        response = self.__send_command(command)
-
-        max_children = int(get_setting('debugger/max_children'))
-        command = 'feature_set -i %d -n max_children -v %d' % (
-            self.__get_transaction_id(),
-            max_children
-        )
-        response = self.__send_command(command)
-
-        max_data = int(get_setting('debugger/max_data'))
-        command = 'feature_set -i %d -n max_data -v %d' % (
-            self.__get_transaction_id(),
-            max_data
-        )
-        response = self.__send_command(command)
+        self.__set_debugger_features()
 
         self.init_message = init_message
 
@@ -228,6 +209,8 @@ def run(self):
                 (index, expression) = data
                 response = self.__evaluate_expression(expression)
                 self.expression_evaluated_signal.emit(index, response)
+            elif action == 'set_debugger_features':
+                self.__set_debugger_features()
         except OSError as error:
             self.disconnect()
             self.connection_error_signal.emit(action, error.strerror)
@@ -291,6 +274,10 @@ def evaluate_expression(self, index, expression):
         self.data = (index, expression)
         self.start()
 
+    def set_debugger_features(self):
+        self.action = 'set_debugger_features'
+        self.start()
+
     def __post_start(self, data):
         post_start_response = {
             'init_breakpoints': self.__set_init_breakpoints(
@@ -429,6 +416,30 @@ def __evaluate_expression(self, expression):
 
         return self.parser.parse_eval_message(response)
 
+    def __set_debugger_features(self):
+        max_depth = int(get_setting('debugger/max_depth'))
+        command = 'feature_set -i %d -n max_depth -v %d' % (
+            self.__get_transaction_id(),
+            max_depth
+        )
+        response = self.__send_command(command)
+
+        max_children = int(get_setting('debugger/max_children'))
+        command = 'feature_set -i %d -n max_children -v %d' % (
+            self.__get_transaction_id(),
+            max_children
+        )
+        response = self.__send_command(command)
+
+        max_data = int(get_setting('debugger/max_data'))
+        command = 'feature_set -i %d -n max_data -v %d' % (
+            self.__get_transaction_id(),
+            max_data
+        )
+        response = self.__send_command(command)
+
+        return True
+
     def __send_command(self, command):
         self.socket.send(bytes(command + '\0', 'utf-8'))
         return self.__receive_message()