when settings change, also emit the new setting values, not just the change setting keys

Author: robertbasic

pugdebug/gui/settings.py

@@ -20,7 +20,7 @@
 
 class PugdebugSettingsWindow(QDialog):
 
-    settings_changed_signal = pyqtSignal(set)
+    settings_changed_signal = pyqtSignal(dict)
 
     def __init__(self, parent):
         super(PugdebugSettingsWindow, self).__init__(parent)

pugdebug/models/settings.py

@@ -162,13 +162,13 @@ def set_setting(key, value):
 
 
 def save_settings(new_settings):
-    changed_settings = set()
+    changed_settings = {}
 
     for key in new_settings:
         value = new_settings[key]
         if not has_setting(key) or get_setting(key) != value:
             set_setting(key, value)
-            changed_settings.add(key)
+            changed_settings[key] = value
 
     return changed_settings
 

pugdebug/pugdebug.py

@@ -417,14 +417,17 @@ def handle_settings_changed(self, changed_settings):
 
         Given argument is a set of settings's names which have been changed.
         """
-        if 'path/project_root' in changed_settings:
+        changed_setting_keys = changed_settings.keys()
+
+        if 'path/project_root' in changed_setting_keys:
             self.handle_project_root_changed()
 
         features = ['debugger/max_depth',
                     'debugger/max_children',
                     'debugger/max_data']
 
-        if any(True for feature in features if feature in changed_settings):
+        if any(True for feature in features
+               if feature in changed_setting_keys):
             self.handle_debugger_features_changed()
 
     def handle_project_root_changed(self):