Skip to content
This repository was archived by the owner on Aug 28, 2020. It is now read-only.

Commit a219209

Browse files
committed
rename signal that gets triggered when a new connection is established
1 parent a4f9507 commit a219209

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

pugdebug/debugger.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ def __init__(self):
5858
def connect_server_signals(self):
5959
"""Connect server signals to slots
6060
"""
61-
self.server.server_connected_signal.connect(
62-
self.handle_server_connected
61+
self.server.new_connection_established_signal.connect(
62+
self.handle_new_connection_established
6363
)
6464
self.server.server_stopped_signal.connect(
6565
self.handle_server_stopped
@@ -164,7 +164,7 @@ def start_listening(self):
164164
"""
165165
self.server.start_listening()
166166

167-
def handle_server_connected(self, connection):
167+
def handle_new_connection_established(self, connection):
168168
"""Handle when the server establishes a new connection
169169
170170
Connect the signals for the new connection.
@@ -178,9 +178,9 @@ def handle_server_connected(self, connection):
178178
self.connections.append(connection)
179179

180180
if not self.is_connected():
181-
self.start_new_connection()
181+
self.start_debugging_new_connection()
182182

183-
def start_new_connection(self):
183+
def start_debugging_new_connection(self):
184184
"""Start a new connection
185185
186186
Get the first (oldest) connection from the queue, set it's init
@@ -241,7 +241,7 @@ def handle_stopped(self):
241241
Otherwise clean up and emit a server stopped signal.
242242
"""
243243
if self.has_pending_connections():
244-
self.start_new_connection()
244+
self.start_debugging_new_connection()
245245
else:
246246
self.cleanup()
247247

pugdebug/server.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class PugdebugServer(QThread):
2323

2424
wait_for_accept = True
2525

26-
server_connected_signal = pyqtSignal(object)
26+
new_connection_established_signal = pyqtSignal(object)
2727
server_stopped_signal = pyqtSignal()
2828

2929
server_error_signal = pyqtSignal(str)
@@ -88,7 +88,9 @@ def __listen(self, socket_server):
8888
is_valid = connection.init_connection()
8989

9090
if is_valid:
91-
self.server_connected_signal.emit(connection)
91+
self.new_connection_established_signal.emit(
92+
connection
93+
)
9294
except socket.timeout:
9395
pass
9496

0 commit comments

Comments
 (0)