rename start_debug to start_listening and add new action stop_listening

Author: robertbasic

pugdebug/gui/main_window.py

@@ -147,27 +147,38 @@ def setup_file_actions(self):
         self.quit_action.triggered.connect(self.close)
 
     def setup_actions(self):
-        self.start_debug_action = QAction("Start", self)
-        self.start_debug_action.setToolTip("Start server (F1)")
-        self.start_debug_action.setStatusTip(
-            "Start listening to for connections. Shortcut: F1"
+        self.start_listening_action = QAction("Start listening", self)
+        self.start_listening_action.setToolTip(
+            "Start listening for new connections (F1)"
         )
-        self.start_debug_action.setShortcut(QKeySequence("F1"))
+        self.start_listening_action.setStatusTip(
+            "Start listening for incomming connections. Shortcut: F1"
+        )
+        self.start_listening_action.setShortcut(QKeySequence("F1"))
+
+        self.stop_listening_action = QAction("Stop listening", self)
+        self.stop_listening_action.setToolTip(
+            "Stop listening for new connections (F2)"
+        )
+        self.stop_listening_action.setStatusTip(
+            "Stop listening to incomming connections. Shortcut: F2"
+        )
+        self.stop_listening_action.setShortcut(QKeySequence("F2"))
 
         self.stop_debug_action = QAction("Stop", self)
-        self.stop_debug_action.setToolTip("Stop server (F2)")
+        self.stop_debug_action.setToolTip("Stop debugging (F3)")
         self.stop_debug_action.setStatusTip(
-            "Stop listening to for connections. Shortcut: F2"
+            "Stop debugging the current request. Shortcut: F3"
         )
-        self.stop_debug_action.setShortcut(QKeySequence("F2"))
+        self.stop_debug_action.setShortcut(QKeySequence("F3"))
 
         self.detach_debug_action = QAction("Detach", self)
-        self.detach_debug_action.setToolTip("Detach from server (F3)")
+        self.detach_debug_action.setToolTip("Detach debugger (F4)")
         self.detach_debug_action.setStatusTip(
-            "Stop the debugging session, but let the PHP process end normally."
-            " Shortcut: F3"
+            "Detach debugger from the current request."
+            " Shortcut: F4"
         )
-        self.detach_debug_action.setShortcut(QKeySequence("F3"))
+        self.detach_debug_action.setShortcut(QKeySequence("F4"))
 
         self.run_debug_action = QAction("Run", self)
         self.run_debug_action.setToolTip("Start/resume the script (F5)")
@@ -208,7 +219,9 @@ def setup_toolbar(self):
         toolbar = QToolBar("Main Toolbar")
         toolbar.setObjectName("main-toolbar")
 
-        toolbar.addAction(self.start_debug_action)
+        toolbar.addAction(self.start_listening_action)
+        toolbar.addAction(self.stop_listening_action)
+        toolbar.addSeparator()
         toolbar.addAction(self.stop_debug_action)
         toolbar.addAction(self.detach_debug_action)
         toolbar.addSeparator()
@@ -235,7 +248,9 @@ def setup_menubar(self):
             view_menu.addAction(widget.toggleViewAction())
 
         debug_menu = menu_bar.addMenu("&Debug")
-        debug_menu.addAction(self.start_debug_action)
+        debug_menu.addAction(self.start_listening_action)
+        debug_menu.addAction(self.stop_listening_action)
+        debug_menu.addSeparator()
         debug_menu.addAction(self.stop_debug_action)
         debug_menu.addAction(self.detach_debug_action)
         debug_menu.addSeparator()
@@ -247,13 +262,14 @@ def setup_menubar(self):
         self.setMenuBar(menu_bar)
 
     def toggle_actions(self, enabled):
+        self.stop_debug_action.setEnabled(enabled)
         self.detach_debug_action.setEnabled(enabled)
         self.run_debug_action.setEnabled(enabled)
         self.step_over_action.setEnabled(enabled)
         self.step_into_action.setEnabled(enabled)
         self.step_out_action.setEnabled(enabled)
 
-        self.start_debug_action.setEnabled(not enabled)
+        self.start_listening_action.setEnabled(not enabled)
 
     def get_file_browser(self):
         return self.file_browser

pugdebug/pugdebug.py

@@ -155,7 +155,12 @@ def connect_toolbar_action_signals(self):
         Connect signals when the run and step continuation commands are
         triggered are connected.
         """
-        self.main_window.start_debug_action.triggered.connect(self.start_debug)
+        self.main_window.start_listening_action.triggered.connect(
+            self.start_listening
+        )
+        self.main_window.stop_listening_action.triggered.connect(
+            self.stop_listening
+        )
         self.main_window.stop_debug_action.triggered.connect(self.stop_debug)
         self.main_window.detach_debug_action.triggered.connect(
             self.detach_debug
@@ -429,8 +434,8 @@ def handle_debugger_features_changed(self):
         if self.debugger.is_connected():
             self.debugger.set_debugger_features()
 
-    def start_debug(self):
-        """Start a new debugging session
+    def start_listening(self):
+        """Start listening to new incomming connections
 
         Clear the variable viewer.
 
@@ -512,6 +517,9 @@ def handle_debugging_post_start(self):
         else:
             self.step_into()
 
+    def stop_listening(self):
+        pass
+
     def stop_debug(self):
         """Stop a debugging session