Merge pull request #89 from ihabunek/feature/stacktrace-jump

When double clicking stack traces, jump to that file/line. Resolves #68

Author: robertbasic

pugdebug/gui/stacktraces.py

@@ -9,11 +9,14 @@
 
 __author__ = "robertbasic"
 
+from PyQt5.QtCore import Qt, pyqtSignal
 from PyQt5.QtWidgets import QTreeWidget, QTreeWidgetItem
 
 
 class PugdebugStacktraceViewer(QTreeWidget):
 
+    item_double_clicked_signal = pyqtSignal(str, int)
+
     def __init__(self):
         super(PugdebugStacktraceViewer, self).__init__()
 
@@ -23,6 +26,8 @@ def __init__(self):
         self.setColumnWidth(0, 350)
         self.setColumnWidth(1, 100)
 
+        self.itemDoubleClicked.connect(self.handle_item_double_clicked)
+
     def set_stacktraces(self, stacktraces):
         self.clear()
 
@@ -35,3 +40,9 @@ def set_stacktraces(self, stacktraces):
             item = QTreeWidgetItem(args)
 
             self.addTopLevelItem(item)
+
+    def handle_item_double_clicked(self, item, column):
+        file = item.text(0)
+        line = int(item.text(1))
+
+        self.item_double_clicked_signal.emit(file, line)

pugdebug/pugdebug.py

@@ -86,6 +86,7 @@ def connect_signals(self):
         self.connect_toolbar_action_signals()
         self.connect_debugger_signals()
         self.connect_expression_viewer_signals()
+        self.connect_stacktrace_viewer_signals()
 
     def connect_file_browser_signals(self):
         """Connect file browser signals
@@ -195,6 +196,11 @@ def connect_expression_viewer_signals(self):
             self.handle_expression_added_or_changed
         )
 
+    def connect_stacktrace_viewer_signals(self):
+        self.stacktrace_viewer.item_double_clicked_signal.connect(
+            self.handle_stacktrace_double_clicked
+        )
+
     def file_browser_item_activated(self, index):
         """Handle when file browser item gets activated
 
@@ -204,7 +210,7 @@ def file_browser_item_activated(self, index):
         if path is not None:
             self.open_document(path, False)
 
-    def open_document(self, path, map_paths=True):
+    def open_document(self, path, map_paths=True, line=None):
         """Open a document
 
         If a document is not already open, open it and add it as a new
@@ -251,9 +257,18 @@ def open_document(self, path, map_paths=True):
                 document_model.filename,
                 path
             )
+
+            # If a line is given, move to that line
+            if line:
+                document_widget.move_to_line(line)
         else:
             # Just focus the tab that has the opened document
-            self.document_viewer.focus_tab(path)
+            index = self.document_viewer.find_tab_index_by_path(path)
+            self.document_viewer.setCurrentIndex(index)
+
+            # If a line is given, move to that line
+            if line:
+                self.document_viewer.get_document(index).move_to_line(line)
 
     def handle_document_double_click(self, path, line_number):
         """Handle when a document gets double clicked
@@ -644,6 +659,13 @@ def handle_expression_added_or_changed(self, index, expression):
         if self.debugger.is_connected():
             self.debugger.evaluate_expression(index, expression)
 
+    def handle_stacktrace_double_clicked(self, file, line):
+        """Handle when an item in the stack trace viewer is double clicked.
+
+        Show the document, and scroll to the given line.
+        """
+        self.open_document(file, True, line)
+
     def handle_error(self, error):
         em = QErrorMessage(self.main_window)
         em.showMessage(error)