chore: Add support for LSP string enumerations

Signed-off-by: Roberto Raggi <[email protected]>

Author: robertoraggi

packages/cxx-gen-lsp/src/gen_enums_cc.ts

@@ -34,6 +34,8 @@ export function gen_enums_cc({ model, outputDirectory }: { model: MetaModel; out
   emit(copyrightHeader);
   emit();
   emit(`#include <cxx/lsp/enums.h>`);
+  emit(`#include <unordered_map>`);
+  emit(`#include <format>`);
   emit();
 
   emit(`namespace cxx::lsp {`);
@@ -58,7 +60,30 @@ export function gen_enums_cc({ model, outputDirectory }: { model: MetaModel; out
     emit(`}`);
   });
 
+  const stringEnums = model.enumerations.filter((enumeration) => enumeration.type.name === "string");
+
   emit();
+  emit(`namespace string_enums {`);
+  stringEnums.forEach((enumeration) => {
+    emit();
+    emit(`auto parse${enumeration.name}(std::string_view name) -> std::optional<${enumeration.name}> {`);
+    emit(`  static std::unordered_map<std::string_view, ${enumeration.name}> map{`);
+    enumeration.values.forEach((enumerator) => {
+      const enumeratorName = getEnumeratorName(enumerator);
+      const text = enumeration.type.name === "string" ? enumerator.value : enumerator.name;
+      emit(`    {"${text}", ${enumeration.name}::${enumeratorName}},`);
+    });
+    emit(`  };`);
+    emit(`  const auto it = map.find(name);`);
+    emit(`  if (it != map.end()) `);
+    emit(`    return it->second;`);
+    emit(`  return std::nullopt;`);
+    emit(`}`);
+  });
+  emit();
+  emit(`} // namespace string_enums`);
+  emit();
+
   emit(`} // namespace cxx::lsp`);
 
   const outputFile = path.join(outputDirectory, "enums.cc");

packages/cxx-gen-lsp/src/gen_enums_h.ts

@@ -36,6 +36,8 @@ export function gen_enums_h({ model, outputDirectory }: { model: MetaModel; outp
   emit(`#pragma once`);
   emit();
   emit(`#include <string>`);
+  emit(`#include <string_view>`);
+  emit(`#include <optional>`);
   emit(`#include <cxx/lsp/fwd.h>`);
   emit();
   emit(`namespace cxx::lsp {`);
@@ -56,6 +58,16 @@ export function gen_enums_h({ model, outputDirectory }: { model: MetaModel; outp
     emit(`auto to_string(${enumeration.name} value) -> std::string;`);
   });
   emit();
+
+  const stringEnums = model.enumerations.filter((enumeration) => enumeration.type.name === "string");
+  emit(`namespace string_enums {`);
+  emit();
+  stringEnums.forEach((enumeration) => {
+    emit(`[[nodiscard]] auto parse${enumeration.name}(std::string_view name) -> std::optional<${enumeration.name}>;`);
+  });
+  emit(`} // namespace string_enums`);
+  emit();
+
   emit(`} // namespace cxx::lsp`);
 
   const outputFile = path.join(outputDirectory, "enums.h");

packages/cxx-gen-lsp/src/gen_types_cc.ts

@@ -80,6 +80,7 @@ class TypeGenerator {
     this.emit(copyrightHeader);
     this.emit();
     this.emit(`#include <cxx/lsp/types.h>`);
+    this.emit(`#include <cxx/lsp/enums.h>`);
     this.emit();
     this.emit(`namespace cxx::lsp {`);
     this.emit();
@@ -268,8 +269,12 @@ class TypeGenerator {
       }
 
       // todo: string-like enumeration
-      console.log(`string-like enumeration: ${property.type.name}`);
-      return false;
+      this.emit(`const auto enumValue = string_enums::parse${property.type.name}(value.get<std::string>());`);
+      this.emit();
+      this.emit(`if (enumValue.has_value()) return *enumValue;`);
+      this.emit();
+      this.emit(`lsp_runtime_error("invalid value for ${property.type.name} enumeration");`);
+      return true;
     }
 
     if (this.typeAliasByName.has(property.type.name)) {
@@ -377,8 +382,9 @@ class TypeGenerator {
         return true;
       }
 
-      // TODO: string-like enumeration
-      return false;
+      // string-like enumeration
+      this.emit(`(*repr_)["${property.name}"] = to_string(${value});`);
+      return true;
     }
 
     if (this.structByName.has(property.type.name)) {

src/frontend/cxx/lsp_server.cc

@@ -444,16 +444,7 @@ void Server::operator()(const CancelNotification& notification) {
 void Server::operator()(const SetTraceNotification& notification) {
   logTrace(std::format("Did receive SetTraceNotification"));
 
-  // TODO: LSP string enumerations
-  const auto traceValue =
-      notification.params().get().at("value").get<std::string>();
-
-  if (traceValue == "messages")
-    trace_ = TraceValue::kMessages;
-  else if (traceValue == "verbose")
-    trace_ = TraceValue::kVerbose;
-  else
-    trace_ = TraceValue::kOff;
+  trace_ = notification.params().value();
 }
 
 void Server::operator()(const LSPRequest& request) {