fix: Ownership of vectors of string properties

Author: robertoraggi

packages/cxx-gen-lsp/src/gen_fwd_h.ts

@@ -51,6 +51,9 @@ public:
   [[nodiscard]] auto size() const -> std::size_t { return repr_->size(); }
   [[nodiscard]] auto empty() const -> bool { return repr_->empty(); }
   [[nodiscard]] auto at(int index) const -> const T& { return repr_->at(index); }
+
+  template <typename... Args>
+  void emplace_back(Args&&... args) { repr_->emplace_back(std::forward<Args>(args)...); }
 };
 
 namespace details {
@@ -161,6 +164,22 @@ struct TryEmplace<TextDocumentSyncKind> {
 
 }  // namespace details
 
+template <>
+class Vector<std::string> final : public LSPObject {
+  public:
+  using LSPObject::LSPObject;
+
+  [[nodiscard]] explicit operator bool() const { return repr_ && repr_->is_array(); }
+  [[nodiscard]] auto size() const -> std::size_t { return repr_->size(); }
+  [[nodiscard]] auto empty() const -> bool { return repr_->empty(); }
+  [[nodiscard]] auto at(int index) const -> std::string {
+    return repr_->at(index);
+  }
+
+  template <typename... Args>
+  void emplace_back(Args&&... args) { repr_->emplace_back(std::forward<Args>(args)...); }
+};
+
 template <typename... Ts>
 class Vector<std::variant<Ts...>> final : public LSPObject {
   public:

src/lsp/cxx/lsp/fwd.h

@@ -487,6 +487,11 @@ class Vector final : public LSPObject {
   [[nodiscard]] auto at(int index) const -> const T& {
     return repr_->at(index);
   }
+
+  template <typename... Args>
+  void emplace_back(Args&&... args) {
+    repr_->emplace_back(std::forward<Args>(args)...);
+  }
 };
 
 namespace details {
@@ -597,6 +602,26 @@ struct TryEmplace<TextDocumentSyncKind> {
 
 }  // namespace details
 
+template <>
+class Vector<std::string> final : public LSPObject {
+ public:
+  using LSPObject::LSPObject;
+
+  [[nodiscard]] explicit operator bool() const {
+    return repr_ && repr_->is_array();
+  }
+  [[nodiscard]] auto size() const -> std::size_t { return repr_->size(); }
+  [[nodiscard]] auto empty() const -> bool { return repr_->empty(); }
+  [[nodiscard]] auto at(int index) const -> std::string {
+    return repr_->at(index);
+  }
+
+  template <typename... Args>
+  void emplace_back(Args&&... args) {
+    repr_->emplace_back(std::forward<Args>(args)...);
+  }
+};
+
 template <typename... Ts>
 class Vector<std::variant<Ts...>> final : public LSPObject {
  public:

src/lsp/tests/test_types.cc

@@ -88,5 +88,34 @@ TEST(LSP, StringProperty) {
   ASSERT_EQ(range.start().line(), 0);
   ASSERT_EQ(range.start().character(), 0);
 
+  range.start().line(1);
+  range.start().character(2);
+  range.end().line(3);
+  range.end().character(4);
+
+  ASSERT_EQ(range.start().line(), 1);
+  ASSERT_EQ(range.start().character(), 2);
+  ASSERT_EQ(range.end().line(), 3);
+  ASSERT_EQ(range.end().character(), 4);
+
   ASSERT_TRUE(location);
-}
+}
+
+TEST(LSP, StringArrayProperty) {
+  json storage = json::object();
+
+  auto textDocumentContentRegistrationOptions =
+      TextDocumentContentRegistrationOptions{storage};
+
+  auto schemas = textDocumentContentRegistrationOptions.schemes();
+  ASSERT_TRUE(schemas.empty());
+
+  schemas.emplace_back("file");
+  schemas.emplace_back("http");
+
+  ASSERT_EQ(schemas.at(0), "file");
+  ASSERT_EQ(schemas.at(1), "http");
+
+  ASSERT_EQ(textDocumentContentRegistrationOptions.schemes().at(0), "file");
+  ASSERT_EQ(textDocumentContentRegistrationOptions.schemes().at(1), "http");
+}