Evaluate static assertions when the CLI is invoked with -fcheck

Signed-off-by: Roberto Raggi <[email protected]>

Author: robertoraggi

src/frontend/cxx/frontend.cc

@@ -314,7 +314,6 @@ auto runOnFile(const CLI& cli, const std::string& fileName) -> bool {
     unit.parse(ParserConfiguration{
         .checkTypes = cli.opt_fcheck,
         .fuzzyTemplateResolution = true,
-        .staticAssert = cli.opt_fstatic_assert || cli.opt_fcheck,
         .reflect = !cli.opt_fno_reflect,
     });
 

src/lsp/cxx/lsp/cxx_document.cc

@@ -271,7 +271,6 @@ void CxxDocument::parse(std::string source) {
   unit.parse(ParserConfiguration{
       .checkTypes = cli.opt_fcheck,
       .fuzzyTemplateResolution = true,
-      .staticAssert = cli.opt_fstatic_assert || cli.opt_fcheck,
       .reflect = !cli.opt_fno_reflect,
       .stopParsingPredicate = stopParsingPredicate,
       .complete = complete,

src/parser/cxx/cli.cc

@@ -146,9 +146,6 @@ std::vector<CLIOptionDescr> options{
 
     {"-fsyntax-only", "Check only the syntax", &CLI::opt_fsyntax_only},
 
-    {"-fstatic-assert", "Enable static asserts", &CLI::opt_fstatic_assert,
-     CLIOptionVisibility::kExperimental},
-
     {"-freport-missing-types", "Report missing types",
      &CLI::opt_freport_missing_types},
 

src/parser/cxx/cli.h

@@ -66,7 +66,6 @@ class CLI {
   bool opt_S = false;
   bool opt_c = false;
   bool opt_fsyntax_only = false;
-  bool opt_fstatic_assert = false;
   bool opt_fcheck = false;
   bool opt_freport_missing_types = false;
   bool opt_fno_reflect = false;

src/parser/cxx/parser.cc

@@ -5281,7 +5281,7 @@ auto Parser::parse_static_assert_declaration(DeclarationAST*& yyast) -> bool {
       value = visit(to_bool, *constValue);
     }
 
-    if (!value && config_.staticAssert) {
+    if (!value && config_.checkTypes) {
       SourceLocation loc = ast->firstSourceLocation();
 
       if (!ast->expression || !constValue.has_value()) {

src/parser/cxx/parser_fwd.h

@@ -47,7 +47,6 @@ using CodeCompletionContext =
 struct ParserConfiguration {
   bool checkTypes = false;
   bool fuzzyTemplateResolution = false;
-  bool staticAssert = false;
   bool reflect = true;
   std::function<bool()> stopParsingPredicate;
   std::function<void(const CodeCompletionContext&)> complete;

tests/api_tests/test_substitution.cc

@@ -52,7 +52,6 @@ struct Source {
     unit.parse({
         .checkTypes = true,
         .fuzzyTemplateResolution = false,
-        .staticAssert = true,
         .reflect = true,
     });
   }