Remove cache of already parsed cast expressions

Signed-off-by: Roberto Raggi <[email protected]>

Author: robertoraggi

src/parser/cxx/parser.cc

@@ -3245,29 +3245,16 @@ auto Parser::parse_cast_expression(ExpressionAST*& yyast,
                                    const ExprContext& ctx) -> bool {
   const auto start = currentLocation();
 
-  if (auto it = cast_expressions_.get(start)) {
-    auto [endLoc, ast, parsed, hit] = *it;
-    rewind(endLoc);
-    yyast = ast;
-    return parsed;
-  }
-
   auto lookat_cast_expression = [&] {
     LookaheadParser lookahead{this};
     if (!parse_cast_expression_helper(yyast, ctx)) return false;
     lookahead.commit();
     return true;
   };
 
-  auto parsed = lookat_cast_expression();
+  if (lookat_cast_expression()) return true;
 
-  if (!parsed) {
-    parsed = parse_unary_expression(yyast, ctx);
-  }
-
-  cast_expressions_.set(start, currentLocation(), yyast, parsed);
-
-  return parsed;
+  return parse_unary_expression(yyast, ctx);
 }
 
 auto Parser::parse_cast_expression_helper(ExpressionAST*& yyast,

src/parser/cxx/parser.h

@@ -972,7 +972,6 @@ class Parser final {
     std::deque<const_iterator> queue_;
   };
 
-  CachedAST<ExpressionAST> cast_expressions_;
   CachedAST<NestedNameSpecifierAST> nested_name_specifiers_;
   CachedAST<ParameterDeclarationClauseAST> parameter_declaration_clauses_;
   CachedAST<TemplateArgumentAST> template_arguments_;