Check new and delete expressions

Author: robertoraggi

src/parser/cxx/ast.h

@@ -1921,6 +1921,7 @@ class NewExpressionAST final : public ExpressionAST {
   DeclaratorAST* declarator = nullptr;
   SourceLocation rparenLoc;
   NewInitializerAST* newInitalizer = nullptr;
+  const Type* objectType = nullptr;
 
   void accept(ASTVisitor* visitor) override { visitor->visit(this); }
 

src/parser/cxx/parser.cc

@@ -2558,13 +2558,15 @@ auto Parser::parse_new_expression(ExpressionAST*& yyast, const ExprContext& ctx)
     lookahead.commit();
 
     NewInitializerAST* newInitializer = nullptr;
-    parse_optional_new_initializer(newInitializer, ctx);
+    parse_optional_new_initializer(newInitializer, decl, ctx);
 
     ast->lparenLoc = lparenLoc;
     ast->typeSpecifierList = typeSpecifierList;
     ast->rparenLoc = rparenLoc;
     ast->newInitalizer = newInitializer;
 
+    ast->objectType = getDeclaratorType(unit, declarator, decl.specs.type());
+
     check(ast);
 
     return true;
@@ -2580,7 +2582,9 @@ auto Parser::parse_new_expression(ExpressionAST*& yyast, const ExprContext& ctx)
 
   (void)parse_declarator(ast->declarator, decl, DeclaratorKind::kNewDeclarator);
 
-  parse_optional_new_initializer(ast->newInitalizer, ctx);
+  parse_optional_new_initializer(ast->newInitalizer, decl, ctx);
+
+  ast->objectType = getDeclaratorType(unit, ast->declarator, decl.specs.type());
 
   check(ast);
 
@@ -2611,6 +2615,7 @@ void Parser::parse_optional_new_placement(NewPlacementAST*& yyast,
 }
 
 void Parser::parse_optional_new_initializer(NewInitializerAST*& yyast,
+                                            Decl& decl,
                                             const ExprContext& ctx) {
   if (BracedInitListAST* bracedInitList = nullptr;
       parse_braced_init_list(bracedInitList, ctx)) {

src/parser/cxx/parser.h

@@ -290,7 +290,7 @@ class Parser final {
                                           const ExprContext& ctx) -> bool;
   void parse_optional_new_placement(NewPlacementAST*& yyast,
                                     const ExprContext& ctx);
-  void parse_optional_new_initializer(NewInitializerAST*& yyast,
+  void parse_optional_new_initializer(NewInitializerAST*& yyast, Decl& decl,
                                       const ExprContext& ctx);
   [[nodiscard]] auto parse_delete_expression(ExpressionAST*& yyast,
                                              const ExprContext& ctx) -> bool;

src/parser/cxx/type_checker.cc

@@ -666,11 +666,38 @@ void TypeChecker::Visitor::operator()(NoexceptExpressionAST* ast) {
   ast->type = control()->getBoolType();
 }
 
-void TypeChecker::Visitor::operator()(NewExpressionAST* ast) {}
+void TypeChecker::Visitor::operator()(NewExpressionAST* ast) {
+  // TODO: decay
+  auto objectType = control()->remove_reference(ast->objectType);
+
+  if (auto arrayType = type_cast<BoundedArrayType>(ast->objectType)) {
+    ast->type = control()->getPointerType(arrayType->elementType());
+  } else if (auto unboundedType =
+                 type_cast<UnboundedArrayType>(ast->objectType)) {
+    ast->type = control()->getPointerType(unboundedType->elementType());
+  } else {
+    ast->type = control()->getPointerType(ast->objectType);
+  }
+
+  ast->valueCategory = ValueCategory::kPrValue;
+}
 
-void TypeChecker::Visitor::operator()(DeleteExpressionAST* ast) {}
+void TypeChecker::Visitor::operator()(DeleteExpressionAST* ast) {
+  ast->type = control()->getVoidType();
+  ast->valueCategory = ValueCategory::kPrValue;
+}
 
-void TypeChecker::Visitor::operator()(CastExpressionAST* ast) {}
+void TypeChecker::Visitor::operator()(CastExpressionAST* ast) {
+  if (ast->typeId) {
+    ast->type = control()->remove_reference(ast->typeId->type);
+    if (control()->is_lvalue_reference(ast->typeId->type))
+      ast->valueCategory = ValueCategory::kLValue;
+    else if (control()->is_rvalue_reference(ast->typeId->type))
+      ast->valueCategory = ValueCategory::kXValue;
+    else
+      ast->valueCategory = ValueCategory::kPrValue;
+  }
+}
 
 void TypeChecker::Visitor::operator()(ImplicitCastExpressionAST* ast) {}
 
@@ -808,7 +835,11 @@ void TypeChecker::Visitor::operator()(TypeTraitExpressionAST* ast) {
 
 void TypeChecker::Visitor::operator()(ConditionExpressionAST* ast) {}
 
-void TypeChecker::Visitor::operator()(EqualInitializerAST* ast) {}
+void TypeChecker::Visitor::operator()(EqualInitializerAST* ast) {
+  if (!ast->expression) return;
+  ast->type = ast->expression->type;
+  ast->valueCategory = ast->expression->valueCategory;
+}
 
 void TypeChecker::Visitor::operator()(BracedInitListAST* ast) {}
 

tests/unit_tests/ast/variadic_function_02.cc

@@ -94,7 +94,7 @@ void ff(int count, ...) {
 // CHECK-NEXT:              statement: compound-statement
 // CHECK-NEXT:                statement-list
 // CHECK-NEXT:                  expression-statement
-// CHECK-NEXT:                    expression: cast-expression
+// CHECK-NEXT:                    expression: cast-expression [prvalue void]
 // CHECK-NEXT:                      type-id: type-id
 // CHECK-NEXT:                        type-specifier-list
 // CHECK-NEXT:                          void-type-specifier