Skip to content

Commit f72fdd2

Browse files
committed
chore: Elminate unnecessary std::vector allocation
1 parent 4da9adc commit f72fdd2

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

packages/cxx-gen-ast/src/gen_ast_encoder_cc.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,8 @@ auto ASTEncoder::operator()(TranslationUnit* unit) -> std::span<const std::uint8
225225
std::vector<flatbuffers::Offset<io::Source>> sources;
226226
for (const auto& source : unit_->preprocessor()->sources()) {
227227
auto file_name = fbb_.CreateString(source.fileName);
228-
std::vector<int> lineOffsets(source.lineOffsets.begin(),
229-
source.lineOffsets.end());
230-
auto line_offsets = fbb_.CreateVector(lineOffsets);
228+
auto line_offsets =
229+
fbb_.CreateVector(source.lineOffsets.data(), source.lineOffsets.size());
231230
sources.push_back(io::CreateSource(fbb_, file_name, line_offsets));
232231
}
233232

src/parser/cxx/flatbuffers/ast_encoder.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,8 @@ auto ASTEncoder::operator()(TranslationUnit* unit)
5252
std::vector<flatbuffers::Offset<io::Source>> sources;
5353
for (const auto& source : unit_->preprocessor()->sources()) {
5454
auto file_name = fbb_.CreateString(source.fileName);
55-
std::vector<int> lineOffsets(source.lineOffsets.begin(),
56-
source.lineOffsets.end());
57-
auto line_offsets = fbb_.CreateVector(lineOffsets);
55+
auto line_offsets =
56+
fbb_.CreateVector(source.lineOffsets.data(), source.lineOffsets.size());
5857
sources.push_back(io::CreateSource(fbb_, file_name, line_offsets));
5958
}
6059

0 commit comments

Comments
 (0)