release: v2.7.228

Author: robertpelloni

CHANGELOG.md

@@ -4,6 +4,13 @@
 
 All notable changes to this project will be documented in this file.
 
+## [2.7.228] — 2026-03-15
+
+- refactor(web/sidebar): added shared `safeStorageGetJson(...)` in `apps/web/src/components/Sidebar.tsx` so stored navigation preference hydration now reads and parses localStorage payloads through one helper instead of repeating inline `safeStorageGet(...)` + `JSON.parse(...)` flows.
+- changed(web/sidebar): collapsed sections, favorites, recent routes, and recent searches now hydrate through the same storage-read path, reducing parse drift and keeping malformed stored payload handling consistent across Sidebar preference surfaces.
+- refactor(web/sidebar): removed the unused component-local `persistRecentRoutes(...)` helper so Sidebar no longer keeps an unreferenced older recent-route persistence path around.
+- test(web/navigation): reran focused nav validation/config suites after the Sidebar storage-read convergence cleanup (`37` tests passing).
+
 ## [2.7.227] — 2026-03-15
 
 - refactor(web/sidebar): added shared `safeStorageRemoveMany(...)` in `apps/web/src/components/Sidebar.tsx` so reset and clear actions now remove persisted navigation preference keys through one helper instead of repeating inline storage deletes.

VERSION

@@ -1 +1 @@
-2.7.227
+2.7.228

VERSION.md

@@ -1 +1 @@
-# Borg Project Version: 2.7.227
+# Borg Project Version: 2.7.228

apps/web/src/components/Sidebar.tsx

@@ -49,6 +49,19 @@ function safeStorageGet(key: string): string | null {
     }
 }
 
+function safeStorageGetJson<T>(key: string): T | null {
+    const raw = safeStorageGet(key);
+    if (!raw) {
+        return null;
+    }
+
+    try {
+        return JSON.parse(raw) as T;
+    } catch {
+        return null;
+    }
+}
+
 function safeStorageSet(key: string, value: string): void {
     const storage = getSafeLocalStorage();
     if (!storage) {
@@ -112,55 +125,39 @@ export function Sidebar({ className }: SidebarProps) {
     const paletteInputRef = useRef<HTMLInputElement | null>(null);
 
     useEffect(() => {
-        try {
-            const raw = safeStorageGet(SIDEBAR_COLLAPSE_STORAGE_KEY);
-            if (!raw) {
-                return;
-            }
-            const parsed = JSON.parse(raw);
-            setCollapsedSections(sanitizeCollapsedSections(parsed, sectionTitles));
-        } catch {
-            // ignore invalid stored state
+        const parsed = safeStorageGetJson<unknown>(SIDEBAR_COLLAPSE_STORAGE_KEY);
+        if (parsed === null) {
+            return;
         }
+
+        setCollapsedSections(sanitizeCollapsedSections(parsed, sectionTitles));
     }, [sectionTitles]);
 
     useEffect(() => {
-        try {
-            const raw = safeStorageGet(SIDEBAR_FAVORITES_STORAGE_KEY);
-            if (!raw) {
-                return;
-            }
-            const parsed = JSON.parse(raw);
-            setFavorites(sanitizeFavoriteRoutes(parsed, allowedNavHrefs));
-        } catch {
-            // ignore invalid stored state
+        const parsed = safeStorageGetJson<unknown>(SIDEBAR_FAVORITES_STORAGE_KEY);
+        if (parsed === null) {
+            return;
         }
+
+        setFavorites(sanitizeFavoriteRoutes(parsed, allowedNavHrefs));
     }, [allowedNavHrefs]);
 
     useEffect(() => {
-        try {
-            const raw = safeStorageGet(SIDEBAR_RECENT_STORAGE_KEY);
-            if (!raw) {
-                return;
-            }
-            const parsed = JSON.parse(raw);
-            setRecentRoutes(sanitizeRecentRoutes(parsed, allowedNavHrefs, MAX_RECENT_ROUTES));
-        } catch {
-            // ignore invalid stored state
+        const parsed = safeStorageGetJson<unknown>(SIDEBAR_RECENT_STORAGE_KEY);
+        if (parsed === null) {
+            return;
         }
+
+        setRecentRoutes(sanitizeRecentRoutes(parsed, allowedNavHrefs, MAX_RECENT_ROUTES));
     }, [allowedNavHrefs]);
 
     useEffect(() => {
-        try {
-            const raw = safeStorageGet(SIDEBAR_RECENT_SEARCHES_STORAGE_KEY);
-            if (!raw) {
-                return;
-            }
-            const parsed = JSON.parse(raw);
-            setRecentSearches(sanitizeRecentSearches(parsed, MAX_RECENT_SEARCHES));
-        } catch {
-            // ignore invalid stored state
+        const parsed = safeStorageGetJson<unknown>(SIDEBAR_RECENT_SEARCHES_STORAGE_KEY);
+        if (parsed === null) {
+            return;
         }
+
+        setRecentSearches(sanitizeRecentSearches(parsed, MAX_RECENT_SEARCHES));
     }, []);
 
     const normalizedPathname = normalizeNavHref(pathname);
@@ -339,12 +336,6 @@ export function Sidebar({ className }: SidebarProps) {
         persistFavorites([...favorites, normalizedHref]);
     };
 
-    const persistRecentRoutes = (next: string[]) => {
-        const normalized = normalizeNavHrefList(next).slice(0, MAX_RECENT_ROUTES);
-        setRecentRoutes(normalized);
-        safeStorageSetJson(SIDEBAR_RECENT_STORAGE_KEY, normalized);
-    };
-
     const persistRecentSearches = (next: string[]) => {
         const sanitized = sanitizeRecentSearches(next, MAX_RECENT_SEARCHES);
         setRecentSearches(sanitized);