Skip to content

Commit dba31cb

Browse files
committed
Fix broken Sync button after 0.15 refactor
In the past, the "notify direct" flag controlled all network syncing, propagating all color changes to other devices on the network. Pressing the UI Sync button only toggled this flag, so "notify direct" was set to false by default. In version 0.15, a separate "master" sync flag was introduced, and the UI Sync button now only activates this master flag. However, the rest of the flag defaults weren't configured to sync anything at all. As a result, users pressing Sync saw *no* syncing at all, leading to multiple bug reports. Defaults are now user-friendly: Enabling Sync on a WLED device syncs all of *its* color changes, whether made via the UI, API or remote button, providing a consistent experience which matches the intended behavior from past WLED versions. Philips Hue sync is now also disabled by default, making the stock defaults focused on WLED devices. Users with other RGB ecosystems can manually enable the Hue or Alexa syncing in the settings.
1 parent 7a52144 commit dba31cb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

wled00/wled.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -697,10 +697,10 @@ WLED_GLOBAL bool receiveNotificationPalette _INIT(true); // apply palet
697697
WLED_GLOBAL bool receiveSegmentOptions _INIT(false); // apply segment options
698698
WLED_GLOBAL bool receiveSegmentBounds _INIT(false); // apply segment bounds (start, stop, offset)
699699
WLED_GLOBAL bool receiveDirect _INIT(true); // receive UDP/Hyperion realtime
700-
WLED_GLOBAL bool notifyDirect _INIT(false); // send notification if change via UI or HTTP API
701-
WLED_GLOBAL bool notifyButton _INIT(false); // send if updated by button or infrared remote
700+
WLED_GLOBAL bool notifyDirect _INIT(true); // send notification if change via UI or HTTP API
701+
WLED_GLOBAL bool notifyButton _INIT(true); // send if updated by button or infrared remote
702702
WLED_GLOBAL bool notifyAlexa _INIT(false); // send notification if updated via Alexa
703-
WLED_GLOBAL bool notifyHue _INIT(true); // send notification if Hue light changes
703+
WLED_GLOBAL bool notifyHue _INIT(false); // send notification if Hue light changes
704704
#endif
705705

706706
// effects

0 commit comments

Comments
 (0)