Add tests for omit options (#65)

* add tests for omit options

* ncc

Author: robherley

__tests__/renderer.test.ts

@@ -216,6 +216,52 @@ describe('renderer', () => {
     expect($('tr')).toHaveLength(5)
   })
 
+  describe('filterPackageResults', () => {
+    it('returns all package results when no omit options are set', async () => {
+      const renderer = await getRenderer()
+      const filtered = (renderer as any).filterPackageResults()
+
+      expect(filtered).toHaveLength(4)
+      expect(filtered).toEqual(renderer.packageResults)
+    })
+
+    it('filters out untested packages when Untested option is set', async () => {
+      const renderer = await getRenderer()
+      renderer.omit.add(OmitOption.Untested)
+      const filtered = (renderer as any).filterPackageResults()
+
+      expect(filtered).toHaveLength(3)
+      filtered.forEach((result: any) => {
+        expect(result.hasTests()).toBe(true)
+      })
+    })
+
+    it('filters out successful packages when Successful option is set', async () => {
+      const renderer = await getRenderer()
+      renderer.omit.add(OmitOption.Successful)
+      const filtered = (renderer as any).filterPackageResults()
+
+      expect(filtered).toHaveLength(2)
+      filtered.forEach((result: any) => {
+        expect(result.onlySuccessfulTests()).toBe(false)
+      })
+    })
+
+    it('applies both filters when both options are set', async () => {
+      const renderer = await getRenderer()
+      renderer.omit.add(OmitOption.Untested)
+      renderer.omit.add(OmitOption.Successful)
+      const filtered = (renderer as any).filterPackageResults()
+
+      // Only 'boom' (failed tests) and 'skipme' (skipped test) should remain
+      expect(filtered).toHaveLength(2)
+      filtered.forEach((result: any) => {
+        expect(result.hasTests()).toBe(true)
+        expect(result.onlySuccessfulTests()).toBe(false)
+      })
+    })
+  })
+
   it('does not render stderr when empty', async () => {
     const renderer = await getRenderer()
     renderer.stderr = ''

dist/index.js

@@ -49,15 +49,7 @@ class Renderer {
    * https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary
    */
   async writeSummary() {
-    const resultsToRender = this.packageResults
-      .filter(result =>
-        this.omit.has(OmitOption.Untested) ? result.hasTests() : true
-      )
-      .filter(result =>
-        this.omit.has(OmitOption.Successful)
-          ? !result.onlySuccessfulTests()
-          : true
-      )
+    const resultsToRender = this.filterPackageResults()
 
     if (resultsToRender.length === 0) {
       core.debug('no packages with tests, skipping render')
@@ -81,6 +73,24 @@ class Renderer {
       .write()
   }
 
+  /**
+   * Filters package results based on omit options
+   * @returns filtered package results to render
+   */
+  private filterPackageResults(): PackageResult[] {
+    let results = this.packageResults
+
+    if (this.omit.has(OmitOption.Untested)) {
+      results = results.filter(result => result.hasTests())
+    }
+
+    if (this.omit.has(OmitOption.Successful)) {
+      results = results.filter(result => !result.onlySuccessfulTests())
+    }
+
+    return results
+  }
+
   /**
    * Filter through test events and calculate the results per package
    * @returns list of package results