Do not use subscriber when no need to

Author: robiningelbrecht

src/PhpUnitExtension.php

@@ -28,6 +28,10 @@ public function bootstrap(PHPUnitConfiguration $configuration, Facade $facade, P
         }
 
         EnsurePrinterIsRegisteredSubscriber::register();
-        $facade->registerSubscriber(new ApplicationFinishedSubscriber($configuration));
+
+        if (!$configuration->displayQuote()) {
+            return;
+        }
+        $facade->registerSubscriber(new ApplicationFinishedSubscriber());
     }
 }

src/Subscriber/Application/ApplicationFinishedSubscriber.php

@@ -4,24 +4,14 @@
 
 use PHPUnit\Event\Application\Finished;
 use PHPUnit\Event\Application\FinishedSubscriber;
-use RobinIngelbrecht\PHPUnitPrettyPrint\Configuration;
 use RobinIngelbrecht\PHPUnitPrettyPrint\Quotes;
 
 use function Termwind\render;
 
 final class ApplicationFinishedSubscriber implements FinishedSubscriber
 {
-    public function __construct(
-        private readonly Configuration $configuration
-    ) {
-    }
-
     public function notify(Finished $event): void
     {
-        if (!$this->configuration->displayQuote()) {
-            return;
-        }
-
         render(sprintf('<div class="bg-green p-2">%s</div>', Quotes::getRandom()));
     }
 }

tests/__snapshots__/OutputTest__testPrintCompactModeAtRunTime__1.txt

@@ -28,18 +28,18 @@
    )
 
 
-  at tests/ExampleTests/TestThatHasAllStatusesTest.php:31
+  at tests/ExampleTests/TestThatHasAllStatusesTest.php:29
+   25▕
+   26▕   public function testFailWithDiff(): void
    27▕   {
    28▕   usleep(self::SLEEP_IN_MICRO_SECONDS);
-   29▕   $this->assertEquals(
+  ➜  29▕   $this->assertEquals(
    30▕   ['one', 'two'],
-  ➜  31▕   ['two', 'one']
+   31▕   ['two', 'one']
    32▕   );
    33▕   }
-   34▕
-   35▕   public function testError(): void
 
-  1   tests/ExampleTests/TestThatHasAllStatusesTest.php:31
+  1   tests/ExampleTests/TestThatHasAllStatusesTest.php:29
 
   ───────────────────
    FAILED  Tests\ExampleTests\TestThatHasAllStatusesTest > error Exception

tests/__snapshots__/OutputTest__testPrintCompactMode__1.txt

@@ -28,18 +28,18 @@
    )
 
 
-  at tests/ExampleTests/TestThatHasAllStatusesTest.php:31
+  at tests/ExampleTests/TestThatHasAllStatusesTest.php:29
+   25▕
+   26▕   public function testFailWithDiff(): void
    27▕   {
    28▕   usleep(self::SLEEP_IN_MICRO_SECONDS);
-   29▕   $this->assertEquals(
+  ➜  29▕   $this->assertEquals(
    30▕   ['one', 'two'],
-  ➜  31▕   ['two', 'one']
+   31▕   ['two', 'one']
    32▕   );
    33▕   }
-   34▕
-   35▕   public function testError(): void
 
-  1   tests/ExampleTests/TestThatHasAllStatusesTest.php:31
+  1   tests/ExampleTests/TestThatHasAllStatusesTest.php:29
 
   ───────────────────
    FAILED  Tests\ExampleTests\TestThatHasAllStatusesTest > error Exception

tests/__snapshots__/OutputTest__testPrintWithoutConfig__1.txt

@@ -39,18 +39,18 @@
    )
 
 
-  at tests/ExampleTests/TestThatHasAllStatusesTest.php:31
+  at tests/ExampleTests/TestThatHasAllStatusesTest.php:29
+   25▕
+   26▕   public function testFailWithDiff(): void
    27▕   {
    28▕   usleep(self::SLEEP_IN_MICRO_SECONDS);
-   29▕   $this->assertEquals(
+  ➜  29▕   $this->assertEquals(
    30▕   ['one', 'two'],
-  ➜  31▕   ['two', 'one']
+   31▕   ['two', 'one']
    32▕   );
    33▕   }
-   34▕
-   35▕   public function testError(): void
 
-  1   tests/ExampleTests/TestThatHasAllStatusesTest.php:31
+  1   tests/ExampleTests/TestThatHasAllStatusesTest.php:29
 
   ───────────────────
    FAILED  Tests\ExampleTests\TestThatHasAllStatusesTest > error Exception