ISSUE #1659: Smarter caching in DbalActivityRepository

Author: robiningelbrecht

config/reference.php

@@ -1098,17 +1098,6 @@
  *     doctrine?: DoctrineConfig,
  *     doctrine_migrations?: DoctrineMigrationsConfig,
  *     twig?: TwigConfig,
- *     "when@dev"?: array{
- *         imports?: ImportsConfig,
- *         parameters?: ParametersConfig,
- *         services?: ServicesConfig,
- *         framework?: FrameworkConfig,
- *         flysystem?: FlysystemConfig,
- *         monolog?: MonologConfig,
- *         doctrine?: DoctrineConfig,
- *         doctrine_migrations?: DoctrineMigrationsConfig,
- *         twig?: TwigConfig,
- *     },
  *     "when@prod"?: array{
  *         imports?: ImportsConfig,
  *         parameters?: ParametersConfig,
@@ -1211,7 +1200,6 @@ public static function config(array $config): array
  *     deprecated?: array{package:string, version:string, message?:string},
  * }
  * @psalm-type RoutesConfig = array{
- *     "when@dev"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
  *     "when@prod"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
  *     "when@test"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
  *     ...<string, RouteConfig|ImportConfig|AliasConfig>

tests/Domain/Activity/DbalActivityRepositoryTest.php

@@ -0,0 +1,70 @@
+<?php
+
+namespace App\Tests\Domain\Activity;
+
+use App\Domain\Activity\ActivityId;
+use App\Domain\Activity\ActivityRepository;
+use App\Domain\Activity\ActivityWithRawData;
+use App\Domain\Activity\ActivityWithRawDataRepository;
+use App\Domain\Activity\DbalActivityRepository;
+use App\Domain\Activity\DbalActivityWithRawDataRepository;
+use App\Infrastructure\Exception\EntityNotFound;
+use App\Infrastructure\ValueObject\Time\SerializableDateTime;
+use App\Tests\ContainerTestCase;
+
+class DbalActivityRepositoryTest extends ContainerTestCase
+{
+    private ActivityRepository $activityRepository;
+    private ActivityWithRawDataRepository $activityWithRawDataRepository;
+
+    public function testFind(): void
+    {
+        $activityOne = ActivityBuilder::fromDefaults()
+            ->withActivityId(ActivityId::fromUnprefixed(1))
+            ->withStartDateTime(SerializableDateTime::fromString('2023-10-10 14:00:34'))
+            ->build();
+        $this->activityWithRawDataRepository->add(ActivityWithRawData::fromState(
+            $activityOne,
+            ['raw' => 'data']
+        ));
+
+        $this->assertEquals(
+            $activityOne,
+            $this->activityRepository->find($activityOne->getId())
+        );
+
+        $activityTwo = ActivityBuilder::fromDefaults()
+            ->withActivityId(ActivityId::fromUnprefixed(2))
+            ->withStartDateTime(SerializableDateTime::fromString('2023-10-10 14:00:34'))
+            ->build();
+        $this->activityWithRawDataRepository->add(ActivityWithRawData::fromState(
+            $activityTwo,
+            ['raw' => 'data']
+        ));
+
+        $this->assertEquals(
+            $activityTwo,
+            $this->activityRepository->find($activityTwo->getId())
+        );
+    }
+
+    public function testItShouldThrowWhenNotFound(): void
+    {
+        $this->expectExceptionObject(new EntityNotFound('Activity "activity-1" not found'));
+        $this->activityRepository->find(ActivityId::fromUnprefixed(1));
+    }
+
+    #[\Override]
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->activityRepository = new DbalActivityRepository(
+            $this->getConnection(),
+        );
+        $this->activityWithRawDataRepository = new DbalActivityWithRawDataRepository(
+            $this->getConnection(),
+            $this->activityRepository,
+        );
+    }
+}