ISSUE #1651: Fix new app version notification

Author: robiningelbrecht

src/Domain/Integration/GitHub/AppUpdateAvailableNotificationCronAction.php

@@ -36,13 +36,14 @@ public function getMutexTtl(): int
 
     public function run(SymfonyStyle $output): void
     {
-        if (AppVersion::getSemanticVersion() === $this->gitHub->getLatestRelease()) {
+        $latestRelease = $this->gitHub->getLatestRelease();
+        if (AppVersion::getSemanticVersion() === $latestRelease) {
             return;
         }
 
         $this->commandBus->dispatch(new SendNotification(
             title: 'New app version available',
-            message: sprintf("We have been busy, %s is finally out! Go see what's new.", AppVersion::getSemanticVersion()),
+            message: sprintf("We have been busy, %s is finally out! Go see what's new.", $latestRelease),
             tags: ['partying_face'],
             actionUrl: Url::fromString('https://github.com/robiningelbrecht/statistics-for-strava/releases'),
         ));

tests/Domain/Integration/GitHub/__snapshots__/AppUpdateAvailableNotificationCronActionTest__testRun__1.json

@@ -3,7 +3,7 @@
         "commandName": "App\\Domain\\Integration\\Notification\\SendNotification\\SendNotification",
         "payload": {
             "title": "New app version available",
-            "message": "We have been busy, v4.3.6 is finally out! Go see what's new.",
+            "message": "We have been busy, v3.8.0 is finally out! Go see what's new.",
             "tags": [
                 "partying_face"
             ],