ISSUE #1499: Fix BC bug for FtpHistory

Author: robiningelbrecht

composer.lock

@@ -467,7 +467,7 @@
  *         max_host_connections?: int, // The maximum number of connections to a single host.
  *         default_options?: array{
  *             headers?: array<string, mixed>,
- *             vars?: list<mixed>,
+ *             vars?: array<string, mixed>,
  *             max_redirects?: int, // The maximum number of redirects to follow.
  *             http_version?: scalar|null, // The default HTTP version, typically 1.1 or 2.0, leave to null for the best version.
  *             resolve?: array<string, scalar|null>,
@@ -490,7 +490,7 @@
  *                 md5?: mixed,
  *             },
  *             crypto_method?: scalar|null, // The minimum version of TLS to accept; must be one of STREAM_CRYPTO_METHOD_TLSv*_CLIENT constants.
- *             extra?: list<mixed>,
+ *             extra?: array<string, mixed>,
  *             rate_limiter?: scalar|null, // Rate limiter name to use for throttling requests. // Default: null
  *             caching?: bool|array{ // Caching configuration.
  *                 enabled?: bool, // Default: false
@@ -543,7 +543,7 @@
  *                 md5?: mixed,
  *             },
  *             crypto_method?: scalar|null, // The minimum version of TLS to accept; must be one of STREAM_CRYPTO_METHOD_TLSv*_CLIENT constants.
- *             extra?: list<mixed>,
+ *             extra?: array<string, mixed>,
  *             rate_limiter?: scalar|null, // Rate limiter name to use for throttling requests. // Default: null
  *             caching?: bool|array{ // Caching configuration.
  *                 enabled?: bool, // Default: false
@@ -1095,17 +1095,6 @@
  *     doctrine?: DoctrineConfig,
  *     doctrine_migrations?: DoctrineMigrationsConfig,
  *     twig?: TwigConfig,
- *     "when@dev"?: array{
- *         imports?: ImportsConfig,
- *         parameters?: ParametersConfig,
- *         services?: ServicesConfig,
- *         framework?: FrameworkConfig,
- *         flysystem?: FlysystemConfig,
- *         monolog?: MonologConfig,
- *         doctrine?: DoctrineConfig,
- *         doctrine_migrations?: DoctrineMigrationsConfig,
- *         twig?: TwigConfig,
- *     },
  *     "when@prod"?: array{
  *         imports?: ImportsConfig,
  *         parameters?: ParametersConfig,
@@ -1208,7 +1197,6 @@ public static function config(array $config): array
  *     deprecated?: array{package:string, version:string, message?:string},
  * }
  * @psalm-type RoutesConfig = array{
- *     "when@dev"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
  *     "when@prod"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
  *     "when@test"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
  *     ...<string, RouteConfig|ImportConfig|AliasConfig>

config/reference.php

@@ -107,7 +107,7 @@ public function exportForAITooling(): array
      */
     public static function fromArray(array $values): self
     {
-        if (empty($values[self::CYCLING_KEY]) && empty($values[self::RUNNING_KEY])) {
+        if (!array_key_exists(self::CYCLING_KEY, $values) && !array_key_exists(self::RUNNING_KEY, $values)) {
             // This is still an old FTP history when we didn't
             // differentiate between cycling and running yet. Make sure it's BC.
             $values[self::CYCLING_KEY] = $values;

src/Domain/Ftp/FtpHistory.php

@@ -1,6 +1,6 @@
 <fg=black;bg=green>StatisticsforStravav4.2.1</>
 
-Runtime:PHP8.5.0(cli)Symfony8.0.0Linux
+Runtime:PHP8.5.0(cli)Symfony8.0.1Linux
 Configurationfiles:
 config.yaml
 configathlete.yaml

tests/Application/__snapshots__/importDataAndBuildAppCronActionTest__testRun__2.txt

@@ -3,7 +3,7 @@ StatisticsforStravav4.2.1
 
 
 
-Runtime:PHP8.5.0(cli)Symfony8.0.0Linux
+Runtime:PHP8.5.0(cli)Symfony8.0.1Linux
 
 Configurationfiles:
 config.yaml

tests/Console/Daemon/__snapshots__/ProcessWebhooksConsoleCommandTest__testExecute__1.txt

@@ -5,7 +5,7 @@ Startedon0811202514:47:03
 
 
 
-Runtime:PHP8.5.0(cli)Symfony8.0.0Linux
+Runtime:PHP8.5.0(cli)Symfony8.0.1Linux
 
 Configurationfiles:
 config.yaml

tests/Console/Daemon/__snapshots__/RunDaemonConsoleCommandTest__testExecute__1.txt

@@ -3,7 +3,7 @@ StatisticsforStravav4.2.1
 
 
 
-Runtime:PHP8.5.0(cli)Symfony8.0.0Linux
+Runtime:PHP8.5.0(cli)Symfony8.0.1Linux
 
 Configurationfiles:
 config.yaml

tests/Console/__snapshots__/BuildAppConsoleCommandTest__testExecute__1.txt

@@ -3,7 +3,7 @@ StatisticsforStravav4.2.1
 
 
 
-Runtime:PHP8.5.0(cli)Symfony8.0.0Linux
+Runtime:PHP8.5.0(cli)Symfony8.0.1Linux
 
 Configurationfiles:
 config.yaml