ISSUE #1617: Streaks widget not displaying streaks correctly

Author: robiningelbrecht

config/reference.php

@@ -1098,17 +1098,6 @@
  *     doctrine?: DoctrineConfig,
  *     doctrine_migrations?: DoctrineMigrationsConfig,
  *     twig?: TwigConfig,
- *     "when@dev"?: array{
- *         imports?: ImportsConfig,
- *         parameters?: ParametersConfig,
- *         services?: ServicesConfig,
- *         framework?: FrameworkConfig,
- *         flysystem?: FlysystemConfig,
- *         monolog?: MonologConfig,
- *         doctrine?: DoctrineConfig,
- *         doctrine_migrations?: DoctrineMigrationsConfig,
- *         twig?: TwigConfig,
- *     },
  *     "when@prod"?: array{
  *         imports?: ImportsConfig,
  *         parameters?: ParametersConfig,
@@ -1211,7 +1200,6 @@ public static function config(array $config): array
  *     deprecated?: array{package:string, version:string, message?:string},
  * }
  * @psalm-type RoutesConfig = array{
- *     "when@dev"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
  *     "when@prod"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
  *     "when@test"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
  *     ...<string, RouteConfig|ImportConfig|AliasConfig>

src/Domain/Rewind/FindStreaks/FindStreaksQueryHandler.php

@@ -16,7 +16,6 @@
 final readonly class FindStreaksQueryHandler implements QueryHandler
 {
     private const string FIRST_DAY_OF_THE_WEEK = 'monday this week';
-    private const string FIRST_DAY_OF_THE_MONTH = 'first day of this month';
 
     public function __construct(
         private Connection $connection,
@@ -84,7 +83,7 @@ private function computeStreaks(array $days): FindStreaksResponse
         $longestMonthStreak = $runningMonthStreak = 1;
 
         $previousDay = array_first($days);
-       $keepTrackOfCurrentDayStreak = $today->diff($previousDay)->days < 2;
+        $keepTrackOfCurrentDayStreak = $today->diff($previousDay)->days < 2;
         $currentDayStreak = $keepTrackOfCurrentDayStreak ? 1 : 0;
 
         $keepTrackOfCurrentWeekStreak = $today->diff($previousDay)->days < 7;
@@ -93,7 +92,7 @@ private function computeStreaks(array $days): FindStreaksResponse
         $monthDiff =
             (($today->getYear() - $previousDay->getYear()) * 12)
             + ($today->getMonthWithoutLeadingZero() - $previousDay->getMonthWithoutLeadingZero());
-       $keepTrackOfCurrentMonthStreak = $monthDiff <= 1;
+        $keepTrackOfCurrentMonthStreak = $monthDiff <= 1;
         $currentMonthStreak = $keepTrackOfCurrentMonthStreak ? 1 : 0;
 
         for ($i = 1; $i < count($days); ++$i) {

tests/Application/Build/BuildDashboardHtml/__snapshots__/BuildDashboardHtmlCommandHandlerTest--testHandle--dashboard-html.html

@@ -3688,7 +3688,7 @@ <h3 class="text-lg font-semibold"> Current streaks</h3>
         </div>
         <div class="grow py-5 border border-gray-200 border-t-4 border-t-strava-orange rounded-sm">
             <div class="text-3xl font-extrabold">
-                0
+                3
             </div>
             <div class="text-sm">months</div>
         </div>

tests/Domain/Rewind/FindStreaks/FindStreaksQueryHandlerTest.php

@@ -86,7 +86,7 @@ public static function provideData(): iterable
     {
         return [
             [
-                PausedClock::fromString('2025-01-10'),
+                PausedClock::fromString('2025-01-11'),
                 new FindStreaksResponse(
                     longestDayStreak: 5,
                     currentDayStreak: 4,