Skip to content

Commit f1a5567

Browse files
ISSUE #1496: Heatmap show full name on hover activity name
1 parent 4b6d01c commit f1a5567

File tree

3 files changed

+32
-15
lines changed

3 files changed

+32
-15
lines changed

config/reference.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,6 +1095,17 @@
10951095
* doctrine?: DoctrineConfig,
10961096
* doctrine_migrations?: DoctrineMigrationsConfig,
10971097
* twig?: TwigConfig,
1098+
* "when@dev"?: array{
1099+
* imports?: ImportsConfig,
1100+
* parameters?: ParametersConfig,
1101+
* services?: ServicesConfig,
1102+
* framework?: FrameworkConfig,
1103+
* flysystem?: FlysystemConfig,
1104+
* monolog?: MonologConfig,
1105+
* doctrine?: DoctrineConfig,
1106+
* doctrine_migrations?: DoctrineMigrationsConfig,
1107+
* twig?: TwigConfig,
1108+
* },
10981109
* "when@prod"?: array{
10991110
* imports?: ImportsConfig,
11001111
* parameters?: ParametersConfig,
@@ -1197,6 +1208,7 @@ public static function config(array $config): array
11971208
* deprecated?: array{package:string, version:string, message?:string},
11981209
* }
11991210
* @psalm-type RoutesConfig = array{
1211+
* "when@dev"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
12001212
* "when@prod"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
12011213
* "when@test"?: array<string, RouteConfig|ImportConfig|AliasConfig>,
12021214
* ...<string, RouteConfig|ImportConfig|AliasConfig>

public/js/dist/app.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/js/ui/heatmap.js

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {DataTableStorage, FilterManager} from "../filters";
2-
import { pointToLineDistance, point, lineString } from "../../libraries/turf";
2+
import {pointToLineDistance, point, lineString} from "../../libraries/turf";
33

44
class HeatmapDrawer {
55
constructor(wrapper, config, modalManager) {
@@ -31,18 +31,7 @@ class HeatmapDrawer {
3131
}
3232
this.map.on("click", (e) => this._handleMapClick(e));
3333
this.map.on("popupclose", () => this._resetRouteStyles());
34-
this.map.on("popupopen", (ev) => {
35-
const container = ev.popup.getElement();
36-
if (!container) return;
37-
38-
container.querySelectorAll('a[data-model-content-url]').forEach(node => {
39-
node.addEventListener("click", (e) => {
40-
e.preventDefault();
41-
e.stopPropagation();
42-
this.modalManager.open(node.getAttribute('data-model-content-url'));
43-
});
44-
});
45-
});
34+
this.map.on("popupopen", (e) => this._handlePopupOpen(e));
4635
}
4736

4837
_resetRouteStyles() {
@@ -51,6 +40,19 @@ class HeatmapDrawer {
5140
});
5241
}
5342

43+
_handlePopupOpen(e) {
44+
const container = e.popup.getElement();
45+
if (!container) return;
46+
47+
container.querySelectorAll('a[data-model-content-url]').forEach(node => {
48+
node.addEventListener("click", (e) => {
49+
e.preventDefault();
50+
e.stopPropagation();
51+
this.modalManager.open(node.getAttribute('data-model-content-url'));
52+
});
53+
});
54+
};
55+
5456
_handleMapClick(e) {
5557
const clickPoint = point([e.latlng.lng, e.latlng.lat]);
5658
const NEARBY_DISTANCE_IN_METERS = 100;
@@ -84,7 +86,10 @@ class HeatmapDrawer {
8486
<ul class="divide-default divide-y divide-gray-200">
8587
${nearby.map(entry => `
8688
<li class="py-2">
87-
<a href="#" class="block truncate font-medium text-blue-600 hover:underline" data-model-content-url="/activity/${entry.route.id}.html"> ${entry.route.name} </a>
89+
<a href="#" title="${entry.route.name}" class="block truncate font-medium text-blue-600 hover:underline"
90+
data-model-content-url="/activity/${entry.route.id}.html">
91+
${entry.route.name}
92+
</a>
8893
<div class="flex items-center justify-between text-xs text-gray-500">
8994
<div>${entry.route.startDate}</div>
9095
<div>${entry.route.distance}</div>

0 commit comments

Comments
 (0)