Skip to content

Commit c6f788c

Browse files
authored
Merge pull request #144 from robinst/jv-ld-library-path
2 parents de92ab5 + 40de297 commit c6f788c

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,4 +82,4 @@ jobs:
8282
run: TAGLIB_DIR=$PWD/tmp/$PLATFORM/taglib-$TAGLIB_VERSION bundle exec rake compile
8383

8484
- name: Run Tests (taglib-ruby)
85-
run: LD_LIBRARY_PATH=$PWD/tmp/$PLATFORM/taglib-$TAGLIB_VERSION/lib bundle exec rake test
85+
run: bundle exec rake test

README.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,18 +120,14 @@ Build a specific version of Taglib:
120120
The above command will automatically download Taglib 1.11.1, build it and
121121
install it in `tmp/x86_64-linux/taglib-1.11.1`.
122122

123-
The `swig` and `compile` tasks can then be executed against that specific
123+
The `swig`, `compile` and `test` tasks can then be executed against that specific
124124
version of Taglib by setting the `TAGLIB_DIR` environment variable to
125125
`$PWD/tmp/x86_64-linux/taglib-1.11.1` (it is assumed that taglib headers are
126126
located at `$TAGLIB_DIR/include` and taglib libraries at `$TAGLIB_DIR/lib`).
127127

128-
The `test` task can then be run for that version of Taglib by adding
129-
`$PWD/tmp/x86_64-linux/taglib-1.11.1/lib` to the `LD_LIBRARY_PATH` environment
130-
variable.
131-
132128
To do everything in one command:
133129

134-
PLATFORM=x86_64-linux TAGLIB_VERSION=1.11.1 TAGLIB_DIR=$PWD/tmp/x86_64-linux/taglib-1.11.1 LD_LIBRARY_PATH=$PWD/tmp/x86_64-linux/taglib-1.11.1/lib rake vendor compile test
130+
PLATFORM=x86_64-linux TAGLIB_VERSION=1.11.1 TAGLIB_DIR=$PWD/tmp/x86_64-linux/taglib-1.11.1 rake vendor compile test
135131

136132
### Workflow
137133

0 commit comments

Comments
 (0)