Skip to content

Commit 531be96

Browse files
authored
Merge pull request moby#50800 from thaJeztah/rm_error_convert
daemon/containerd: remove convertError utility
2 parents f5df9ee + c5e75cc commit 531be96

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

daemon/containerd/image.go

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,6 @@ func (i *ImageService) getImageLabelByDigest(ctx context.Context, target digest.
248248
return value, nil
249249
}
250250

251-
func convertError(err error) error {
252-
// TODO: Convert containerd error to Docker error
253-
return err
254-
}
255-
256251
// resolveAllReferences resolves the reference name or ID to an image and returns all the images with
257252
// the same target.
258253
//
@@ -293,7 +288,7 @@ func (i *ImageService) resolveAllReferences(ctx context.Context, refOrID string)
293288
dgst = cimg.Target.Digest
294289
}
295290
} else if !cerrdefs.IsNotFound(err) {
296-
return nil, nil, convertError(err)
291+
return nil, nil, err
297292
} else {
298293
dgst = d.Digest()
299294
}
@@ -305,7 +300,7 @@ func (i *ImageService) resolveAllReferences(ctx context.Context, refOrID string)
305300
}
306301
imgs, err := i.images.List(ctx, filters...)
307302
if err != nil {
308-
return nil, nil, convertError(err)
303+
return nil, nil, err
309304
}
310305

311306
if len(imgs) == 0 {
@@ -347,7 +342,7 @@ func (i *ImageService) resolveAllReferences(ctx context.Context, refOrID string)
347342
cimg, err := i.images.Get(ctx, name)
348343
if err != nil {
349344
if !cerrdefs.IsNotFound(err) {
350-
return nil, nil, convertError(err)
345+
return nil, nil, err
351346
}
352347
// If digest is given, continue looking up for matching targets.
353348
// There will be no exact match found but the caller may attempt

0 commit comments

Comments
 (0)