Skip to content

Commit e7d7771

Browse files
authored
Merge pull request moby#51483 from thaJeztah/rm_MinConnectTimeout
daemon: remove workaround for c8d client connection timeout
2 parents fb2ca99 + 7e78088 commit e7d7771

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

daemon/daemon.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -969,8 +969,6 @@ func NewDaemon(ctx context.Context, config *config.Config, pluginStore *plugin.S
969969
backoffConfig.MaxDelay = connTimeout
970970
connParams := grpc.ConnectParams{
971971
Backoff: backoffConfig,
972-
// TODO: Remove after https://github.com/containerd/containerd/pull/11508
973-
MinConnectTimeout: connTimeout,
974972
}
975973
gopts := []grpc.DialOption{
976974
// ------------------------------------------------------------------

daemon/internal/libcontainerd/supervisor/remote_daemon.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -280,19 +280,14 @@ func (r *remote) monitorDaemon(ctx context.Context) {
280280
continue
281281
}
282282

283-
const connTimeout = 60 * time.Second
284283
client, err = containerd.New(
285284
r.GRPC.Address,
286-
containerd.WithTimeout(connTimeout),
285+
containerd.WithTimeout(60*time.Second),
287286
containerd.WithDialOpts([]grpc.DialOption{
288287
grpc.WithTransportCredentials(insecure.NewCredentials()),
289288
grpc.WithContextDialer(dialer.ContextDialer),
290289
grpc.WithUnaryInterceptor(grpcerrors.UnaryClientInterceptor),
291290
grpc.WithStreamInterceptor(grpcerrors.StreamClientInterceptor),
292-
grpc.WithConnectParams(grpc.ConnectParams{
293-
// TODO: Remove after https://github.com/containerd/containerd/pull/11508
294-
MinConnectTimeout: connTimeout,
295-
}),
296291
}),
297292
)
298293
if err != nil {

0 commit comments

Comments
 (0)