Skip to content

Commit ee69d8a

Browse files
authored
Merge pull request moby#50051 from robmry/nftables_no_docker_user
nftables: don't create DOCKER-USER iptables chains
2 parents e2b9f3d + a2652d4 commit ee69d8a

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

libnetwork/firewall_linux.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ func (c *Controller) selectFirewallBackend() {
2424
// Sets up the DOCKER-USER chain for each iptables version (IPv4, IPv6) that's
2525
// enabled in the controller's configuration.
2626
func (c *Controller) setupUserChains() {
27+
// There's no equivalent to DOCKER-USER in the nftables implementation.
28+
if nftables.Enabled() {
29+
return
30+
}
31+
2732
setup := func() error {
2833
var errs []error
2934
for _, ipVersion := range c.enabledIptablesVersions() {

libnetwork/firewall_linux_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,18 @@ import (
66
"strings"
77
"testing"
88

9-
"github.com/docker/docker/libnetwork/drivers/bridge"
10-
119
"github.com/docker/docker/internal/testutils/netnsutils"
1210
"github.com/docker/docker/libnetwork/config"
11+
"github.com/docker/docker/libnetwork/drivers/bridge"
12+
"github.com/docker/docker/libnetwork/internal/nftables"
1313
"github.com/docker/docker/libnetwork/iptables"
1414
"github.com/docker/docker/libnetwork/netlabel"
1515
"github.com/docker/docker/libnetwork/options"
1616
"gotest.tools/v3/assert"
1717
is "gotest.tools/v3/assert/cmp"
1818
"gotest.tools/v3/golden"
1919
"gotest.tools/v3/icmd"
20+
"gotest.tools/v3/skip"
2021
)
2122

2223
const (
@@ -71,6 +72,7 @@ func TestUserChain(t *testing.T) {
7172
}))
7273
assert.NilError(t, err)
7374
defer c.Stop()
75+
skip.If(t, nftables.Enabled(), "nftables is enabled, skipping iptables test")
7476

7577
// init. condition
7678
golden.Assert(t, getRules(t, iptable4, fwdChainName),

0 commit comments

Comments
 (0)