Skip to content

Commit fa4f3c9

Browse files
committed
gha: remove GO_VERSION build-arg from builds
The same env-var is used for action/setup-go as for overriding the default Go version in Dockerfiles, however action/setup-go only accepts SemVer (e.g. 1.25.0-rc.1) whereas the official golang image follows the Go project's versioning, which doesn't use a SemVer-compatible format (go1.25rc1 / 1.25rc1). Trying to use the same "GO_VERSION" value for both will therefore fail. As we're already updating the default version in the Dockerfile to the version we want to use, let's remove the --build-arg, and use the default that's set in the Dockerfile. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 3b50d0d commit fa4f3c9

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

.github/workflows/.windows.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ jobs:
9292
& docker build `
9393
--build-arg WINDOWS_BASE_IMAGE `
9494
--build-arg WINDOWS_BASE_IMAGE_TAG `
95-
--build-arg GO_VERSION `
9695
-t ${{ env.TEST_IMAGE_NAME }} `
9796
-f Dockerfile.windows .
9897
-
@@ -172,7 +171,6 @@ jobs:
172171
& docker build `
173172
--build-arg WINDOWS_BASE_IMAGE `
174173
--build-arg WINDOWS_BASE_IMAGE_TAG `
175-
--build-arg GO_VERSION `
176174
-t ${{ env.TEST_IMAGE_NAME }} `
177175
-f Dockerfile.windows .
178176
-

.github/workflows/buildkit.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ jobs:
220220
& docker build `
221221
--build-arg WINDOWS_BASE_IMAGE `
222222
--build-arg WINDOWS_BASE_IMAGE_TAG `
223-
--build-arg GO_VERSION `
224223
-t ${{ env.TEST_IMAGE_NAME }} `
225224
-f Dockerfile.windows .
226225

0 commit comments

Comments
 (0)