Remove shellcheck

The github permissions are currently blocking PRs from forks from
writing checks/review commands. We cannot use workflow permissions to
give write permissions to runs from forks.

Options are to shuffle the work into a workflow_run triggered after the
lint, so we can use the workflow_permissions. Or use
pull_request_target. Or use a PAT with write permissions.

Signed-off-by: Robert Young <robertyoungnz@gmail.com>

Author: robobario

.github/workflows/lint.yaml

@@ -54,20 +54,6 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           mvn -B -Pci -T1.5C verify -DskipTests -Djapicmp.skip=true
-      - name: shellcheck
-        uses: reviewdog/action-shellcheck@4c07458293ac342d477251099501a718ae5ef86e
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-          reporter: github-pr-review # Change reporter.
-          path: "." # Optional.
-          pattern: "*.sh" # Optional.
-          level: "error"
-          fail_level: "error"
-          exclude: |
-            "./.git/*" 
-            "**/target"
-          check_all_files_with_shebangs: "false" # Optional.
-          shellcheck_flags: "--external-sources --severity=error"
       - name: Save PR number to file
         if: github.event_name == 'pull_request'
         run: echo ${{ github.event.number }} > PR_NUMBER.txt