Skip to content

Commit 205f169

Browse files
committed
Changed:
* updated version of Trilib 2 * Outline of aimied object is now hidden, so the highlighted focus points are clearly visible
1 parent fc0ef1b commit 205f169

File tree

4 files changed

+31
-1
lines changed

4 files changed

+31
-1
lines changed

arcor2_AREditor/Assets/TABLET/Models/ActionModel.stl.meta

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

arcor2_AREditor/Assets/TABLET/Scripts/ActionObject3D.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -459,4 +459,12 @@ public override void UpdateModel() {
459459
Model.transform.localScale = new Vector3(dimensions.Value.x, dimensions.Value.y, dimensions.Value.z);
460460

461461
}
462+
463+
public void Highlight() {
464+
outlineOnClick.Highlight();
465+
}
466+
467+
public void UnHighlight() {
468+
outlineOnClick.UnHighlight();
469+
}
462470
}

arcor2_AREditor/Assets/TABLET/Scripts/GUI/ActionObjectAimingMenu.cs

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,8 @@ public async Task UpdateMenu() {
193193
CancelAimingButton.SetInteractivity(true);
194194
await CheckDoneBtn();
195195
AimingInProgress = true;
196+
if (currentObject is ActionObject3D actionObject3D)
197+
actionObject3D.UnHighlight();
196198
UpdateCurrentPointLabel();
197199
if (!automaticPointSelection && currentObject.ActionObjectMetadata.ObjectModel.Mesh.FocusPoints.Count > 1) {
198200
NextButton.SetInteractivity(true);
@@ -207,6 +209,8 @@ public async Task UpdateMenu() {
207209
SavePositionButton.SetInteractivity(false, "No aiming in progress");
208210
CancelAimingButton.SetInteractivity(false, "No aiming in progress");
209211
AimingInProgress = false;
212+
if (currentObject is ActionObject3D actionObject3D)
213+
actionObject3D.Highlight();
210214
}
211215
} else if (!currentObject.IsRobot() && !currentObject.IsCamera() && currentObject.ActionObjectMetadata.ObjectModel != null) {
212216
UpdatePositionBlockVO.SetActive(true);
@@ -271,6 +275,8 @@ public async void CancelAiming() {
271275
try {
272276
await WebsocketManager.Instance.CancelObjectAiming();
273277
AimingInProgress = false;
278+
if (currentObject is ActionObject3D actionObject3D)
279+
actionObject3D.Highlight();
274280
if (currentFocusPoint >= 0 && currentFocusPoint < spheres.Count)
275281
spheres[currentFocusPoint].UnHighlight();
276282
UpdateCurrentPointLabel();
@@ -319,6 +325,8 @@ await WebsocketManager.Instance.ObjectAimingStart(currentObject.Data.Id,
319325
SavePositionButton.SetInteractivity(true);
320326
CancelAimingButton.SetInteractivity(true);
321327
StartObjectFocusingButton.SetInteractivity(false, "Already aiming");
328+
if (currentObject is ActionObject3D actionObject3D)
329+
actionObject3D.UnHighlight();
322330
if (!automaticPointSelection && currentObject.ActionObjectMetadata.ObjectModel.Mesh.FocusPoints.Count > 1) {
323331
NextButton.SetInteractivity(true);
324332
PreviousButton.SetInteractivity(true);
@@ -332,6 +340,8 @@ await WebsocketManager.Instance.ObjectAimingStart(currentObject.Data.Id,
332340
CurrentPointLabel.text = "";
333341
currentFocusPoint = -1;
334342
AimingInProgress = false;
343+
if (currentObject is ActionObject3D actionObject3D)
344+
actionObject3D.Highlight();
335345
if (ex.Message == "Focusing already started.") { //TODO HACK! find better solution
336346
FocusObjectDone();
337347
}
@@ -368,6 +378,8 @@ public async void FocusObjectDone() {
368378
PreviousButton.SetInteractivity(false, "No aiming in progress");
369379
SavePositionButton.SetInteractivity(false, "No aiming in progress");
370380
StartObjectFocusingButton.SetInteractivity(true);
381+
if (currentObject is ActionObject3D actionObject3D)
382+
actionObject3D.Highlight();
371383
AimingInProgress = false;
372384
} catch (Base.RequestFailedException ex) {
373385
Base.NotificationsModernUI.Instance.ShowNotification("Failed to focus object", ex.Message);
@@ -485,4 +497,13 @@ public void OpenSteppingMenu() {
485497
EditorHelper.EnableCanvasGroup(CanvasGroup, false);
486498
}
487499

500+
public void Highlight(bool enable) {
501+
if (currentObject != null && currentObject is ActionObject3D actionObject) {
502+
if (enable)
503+
actionObject.Highlight();
504+
else
505+
actionObject.UnHighlight();
506+
}
507+
}
508+
488509
}

arcor2_AREditor/Assets/TABLET/Scripts/GUI/LeftMenuScene.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ private async void CancelObjectAiming() {
131131
try {
132132
await WebsocketManager.Instance.CancelObjectAiming();
133133
ActionObjectAimingMenu.Instance.AimingInProgress = false;
134+
ActionObjectAimingMenu.Instance.Highlight(true);
134135
DeactivateAllSubmenus();
135136
ConfirmationDialog.Close();
136137
} catch (RequestFailedException ex) {

0 commit comments

Comments
 (0)