Merge pull request #402 from roboflow/cursor/address-pr-comments-and-fix-1a1d

Address pr comments and fix

Author: digaobarbosa

roboflow/core/version.py

@@ -290,13 +290,13 @@ def export(self, model_format=None):
             except json.JSONDecodeError:
                 response.raise_for_status()
 
-    def train(self, speed=None, modelType=None, checkpoint=None, plot_in_notebook=False) -> InferenceModel:
+    def train(self, speed=None, model_type=None, checkpoint=None, plot_in_notebook=False) -> InferenceModel:
         """
         Ask the Roboflow API to train a previously exported version's dataset.
 
         Args:
             speed: Whether to train quickly or accurately. Note: accurate training is a paid feature. Default speed is `fast`.
-            modelType: The type of model to train. Default depends on kind of project. It takes precedence over speed. You can check the list of model ids by sending a invalid parameter in this argument.
+            model_type: The type of model to train. Default depends on kind of project. It takes precedence over speed. You can check the list of model ids by sending an invalid parameter in this argument.
             checkpoint: A string representing the checkpoint to use while training
             plot: Whether to plot the training results. Default is `False`.
 
@@ -329,14 +329,16 @@ def train(self, speed=None, modelType=None, checkpoint=None, plot_in_notebook=Fa
         url = f"{API_URL}/{workspace}/{project}/{self.version}/train"
 
         data = {}
-        if modelType:
-            data["modelType"] = modelType
+        # Keep existing order to avoid unnecessary diffs; append new field without reordering
+        if speed:
+            data["speed"] = speed
 
         if checkpoint:
             data["checkpoint"] = checkpoint
 
-        if speed:
-            data["speed"] = speed
+        if model_type:
+            # API expects camelCase key
+            data["modelType"] = model_type
 
         write_line("Reaching out to Roboflow to start training...")
 

roboflow/roboflowpy.py

@@ -21,10 +21,10 @@ def login(args):
 
 def train(args):
     rf = roboflow.Roboflow()
-    workspace = rf.workspace(args.workspace) if args.workspace else rf.workspace()
+    workspace = rf.workspace(args.workspace)  # handles None internally
     project = workspace.project(args.project)
     version = project.version(args.version_number)
-    model = version.train(modelType=args.modelType, checkpoint=args.checkpoint)
+    model = version.train(model_type=args.model_type, checkpoint=args.checkpoint)
     print(model)
 
 
@@ -340,7 +340,7 @@ def _add_train_parser(subparsers):
     )
     train_parser.add_argument(
         "-t",
-        dest="modelType",
+        dest="model_type",
         help="type of the model to train (e.g., rfdetr-nano, yolov8n)",
     )
     train_parser.add_argument(