more refactorings and code cleanup

Author: d-biehl

robotcode/language_server/robotframework/parts/formatting.py

@@ -7,13 +7,7 @@
 
 from ....utils.logging import LoggingDescriptor
 from ...common.language import language_id
-from ...common.lsp_types import (
-    FormattingOptions,
-    MessageType,
-    Position,
-    Range,
-    TextEdit,
-)
+from ...common.lsp_types import FormattingOptions, Position, Range, TextEdit
 from ...common.text_document import TextDocument
 
 if TYPE_CHECKING:
@@ -115,7 +109,7 @@ async def format_robot_tidy(
         except (SystemExit, KeyboardInterrupt, asyncio.CancelledError):
             raise
         except BaseException as e:
-            self.parent.window.show_message(str(e), MessageType.Error)
+            self._logger.exception(e)
         return None
 
     async def format_internal(

robotcode/language_server/robotframework/parts/robocop_diagnostics.py

@@ -61,8 +61,8 @@ async def collect_diagnostics(self, sender: Any, document: TextDocument) -> Diag
                     return DiagnosticsResult(self.collect_diagnostics, result)
         except (SystemExit, KeyboardInterrupt, asyncio.CancelledError):
             raise
-        except BaseException:
-            pass
+        except BaseException as e:
+            self._logger.exception(e)
 
         return DiagnosticsResult(self.collect_diagnostics, [])
 

vscode-client/extension.ts

@@ -32,12 +32,15 @@ export async function activateAsync(context: vscode.ExtensionContext): Promise<v
     testControllerManger,
 
     vscode.window.registerTerminalLinkProvider({
-      provideTerminalLinks(context: vscode.TerminalLinkContext, _token: vscode.CancellationToken) {
-        if ((context.line.startsWith("Log:") || context.line.startsWith("Report:")) && context.line.endsWith("html")) {
-          const result = /(Log|Report):\s*(?<link>\S.*)/.exec(context.line)?.groups?.link;
+      provideTerminalLinks(terminalContext: vscode.TerminalLinkContext, _token: vscode.CancellationToken) {
+        if (
+          (terminalContext.line.startsWith("Log:") || terminalContext.line.startsWith("Report:")) &&
+          terminalContext.line.endsWith("html")
+        ) {
+          const result = /(Log|Report):\s*(?<link>\S.*)/.exec(terminalContext.line)?.groups?.link;
 
           if (result) {
-            return [new TerminalLink(result, context.line.indexOf(result), result.length, "Open report.")];
+            return [new TerminalLink(result, terminalContext.line.indexOf(result), result.length, "Open report.")];
           }
         }
 
@@ -79,9 +82,9 @@ function displayProgress<R>(promise: Promise<R>): Thenable<R> {
 }
 
 export async function activate(context: vscode.ExtensionContext): Promise<void> {
-  return await displayProgress(activateAsync(context));
+  return displayProgress(activateAsync(context));
 }
 
 export async function deactivate(): Promise<void> {
-  return await languageClientManger.stopAllClients();
+  return languageClientManger.stopAllClients();
 }

vscode-client/languageclientsmanger.ts

@@ -44,15 +44,15 @@ export class LanguageClientsManager {
     public readonly outputChannel: vscode.OutputChannel
   ) {
     this._disposables = vscode.Disposable.from(
-      this.pythonManager.pythonExtension?.exports.settings.onDidChangeExecutionDetails(
-        async (_event) => await this.refresh()
+      this.pythonManager.pythonExtension?.exports.settings.onDidChangeExecutionDetails(async (_event) =>
+        this.refresh()
       ) ?? {
         dispose() {
           //empty
         },
       },
-      vscode.workspace.onDidChangeWorkspaceFolders(async (_event) => await this.refresh()),
-      vscode.workspace.onDidOpenTextDocument(async (document) => await this.getLanguageClientForDocument(document))
+      vscode.workspace.onDidChangeWorkspaceFolders(async (_event) => this.refresh()),
+      vscode.workspace.onDidOpenTextDocument(async (document) => this.getLanguageClientForDocument(document))
     );
   }
 
@@ -70,7 +70,10 @@ export class LanguageClientsManager {
   }
 
   dispose(): void {
-    void this.stopAllClients().then();
+    this.stopAllClients().then(
+      (_) => undefined,
+      (_) => undefined
+    );
 
     this._disposables.dispose();
   }
@@ -127,11 +130,11 @@ export class LanguageClientsManager {
   public async getLanguageClientForDocument(document: vscode.TextDocument): Promise<LanguageClient | undefined> {
     if (document.languageId !== "robotframework") return;
 
-    return await this.getLanguageClientForResource(document.uri);
+    return this.getLanguageClientForResource(document.uri);
   }
 
   public async getLanguageClientForResource(resource: string | vscode.Uri): Promise<LanguageClient | undefined> {
-    return await this.clientsMutex.dispatch(async () => {
+    return this.clientsMutex.dispatch(async () => {
       const uri = resource instanceof vscode.Uri ? resource : vscode.Uri.parse(resource);
       const workspaceFolder = vscode.workspace.getWorkspaceFolder(uri);
 
@@ -232,25 +235,23 @@ export class LanguageClientsManager {
 
     if (!client) return;
 
-    const result =
+    return (
       (await client.sendRequest<RobotTestItem[]>("robot/discovering/getTestsFromWorkspace", {
         paths: paths ?? ["."],
-      })) ?? undefined;
-
-    return result;
+      })) ?? undefined
+    );
   }
 
   public async getTestsFromDocument(document: vscode.TextDocument, id?: string): Promise<RobotTestItem[] | undefined> {
     const client = await this.getLanguageClientForResource(document.uri);
 
     if (!client) return;
 
-    const result =
+    return (
       (await client.sendRequest<RobotTestItem[]>("robot/discovering/getTestsFromDocument", {
         textDocument: { uri: document.uri.toString() },
         id: id,
-      })) ?? undefined;
-
-    return result;
+      })) ?? undefined
+    );
   }
 }

vscode-client/pythonmanger.ts

@@ -98,11 +98,17 @@ export class PythonManager {
       try {
         this._pythonExtension = vscode.extensions.getExtension("ms-python.python")!;
 
-        void this._pythonExtension.activate().then();
+        this._pythonExtension.activate().then(
+          (_) => undefined,
+          (_) => undefined
+        );
 
         this.outputChannel.appendLine("Python Extension is active");
 
-        void this._pythonExtension.exports.ready.then();
+        this._pythonExtension.exports.ready.then(
+          (_) => undefined,
+          (_) => undefined
+        );
       } catch (ex) {
         this.outputChannel.appendLine("can't activate python extension");
       }

vscode-client/testcontrollermanager.ts

@@ -63,21 +63,21 @@ export class TestControllerManager {
     this.runProfile = this.testController.createRunProfile(
       "Run Tests",
       vscode.TestRunProfileKind.Run,
-      async (request, token) => await this.runTests(request, token)
+      async (request, token) => this.runTests(request, token)
     );
 
     this.debugProfile = this.testController.createRunProfile(
       "Debug",
       vscode.TestRunProfileKind.Debug,
-      async (request, token) => await this.runTests(request, token)
+      async (request, token) => this.runTests(request, token)
     );
 
-    this.testController.resolveHandler = async (item) => await this.refresh(item);
+    this.testController.resolveHandler = async (item) => this.refresh(item);
 
     const fileWatcher = vscode.workspace.createFileSystemWatcher("**/*");
-    fileWatcher.onDidCreate(async (uri) => await this.refreshFromUri(uri, "create"));
-    fileWatcher.onDidDelete(async (uri) => await this.refreshFromUri(uri, "delete"));
-    fileWatcher.onDidChange(async (uri) => await this.refreshFromUri(uri, "change"));
+    fileWatcher.onDidCreate(async (uri) => this.refreshFromUri(uri, "create"));
+    fileWatcher.onDidDelete(async (uri) => this.refreshFromUri(uri, "delete"));
+    fileWatcher.onDidChange(async (uri) => this.refreshFromUri(uri, "change"));
 
     this._disposables = vscode.Disposable.from(
       fileWatcher,