use 'open' package to open reports externally

Author: d-biehl

package.json

@@ -493,6 +493,7 @@
         "ms-python.python"
     ],
     "dependencies": {
+        "open": "^8.2.0",
         "vscode-debugadapter": "^1.47.0",
         "vscode-debugprotocol": "^1.47.0",
         "vscode-languageclient": "^7.0.0",
@@ -501,7 +502,7 @@
     "devDependencies": {
         "@types/glob": "^7.1.3",
         "@types/mocha": "^8.2.2",
-        "@types/node": "^15.12.2",
+        "@types/node": "^15.12.2",        
         "@types/vscode": "^1.56.0",
         "@typescript-eslint/eslint-plugin": "^4.26.1",
         "@typescript-eslint/parser": "^4.26.1",

tsconfig.json

@@ -15,15 +15,16 @@
 		"rootDir": "vscode-client",
 		"strict": true,
 		"experimentalDecorators": true,
-		"allowSyntheticDefaultImports": true,
+		//"esModuleInterop": true,
+		//"allowSyntheticDefaultImports": true,
 		"noImplicitAny": true,
 		"noImplicitThis": true,
 		"noUnusedLocals": true,
 		//"noUnusedParameters": true,
 		"noFallthroughCasesInSwitch": true,
 		"resolveJsonModule": true,
 		"removeComments": true,
-		"noImplicitReturns": true,
+		"noImplicitReturns": true,				
 	},
 	"exclude": [
 		"node_modules",

vscode-client/extension.ts

@@ -3,6 +3,7 @@ import * as path from "path";
 import * as vscode from "vscode";
 import { LanguageClient, LanguageClientOptions, ServerOptions } from "vscode-languageclient/node";
 import { sleep, Mutex } from "./utils";
+import openExternal = require("open");
 
 const LANGUAGE_SERVER_DEFAULT_TCP_PORT = 6610;
 const LANGUAGE_SERVER_DEFAULT_HOST = "127.0.0.1";
@@ -45,7 +46,6 @@ let clientsMutex = new Mutex();
 let clients: Map<string, LanguageClient> = new Map();
 
 async function updateLoadedDocumentClients(uri?: vscode.Uri | undefined) {
-    OUTPUT_CHANNEL.appendLine("initialze/restart all needed language clients.");
     await clientsMutex.dispatch(async () => {
         for (let client of clients.values()) {
             await client.stop().catch((_) => {});
@@ -481,6 +481,10 @@ async function attachPython(session: vscode.DebugSession, event: string, options
     }
 }
 
+async function openReport(file: string) {
+    await openExternal(file);
+}
+
 async function onRobotExited(session: vscode.DebugSession, outputFile?: string, logFile?: string, reportFile?: string) {
     if (reportFile) {
         let config = vscode.workspace.getConfiguration(CONFIG_SECTION, session.workspaceFolder);
@@ -489,7 +493,7 @@ async function onRobotExited(session: vscode.DebugSession, outputFile?: string,
             case "disabled":
                 return;
             case "external":
-                vscode.env.openExternal(vscode.Uri.file(reportFile));
+                openReport(reportFile);
         }
     }
 }
@@ -642,13 +646,13 @@ export async function activateAsync(context: vscode.ExtensionContext) {
 
                 switch (config.get<string>("run.openReportAfterRun")) {
                     default:
-                        vscode.env.openExternal(vscode.Uri.file(link.path));
+                        openReport(link.path);
                         break;
                 }
             },
         }),
 
-        vscode.workspace.onDidChangeConfiguration((event) => {
+        vscode.workspace.onDidChangeConfiguration(async (event) => {
             for (let s of [
                 "robotcode.python",
                 "robotcode.languageServer.mode",
@@ -662,7 +666,7 @@ export async function activateAsync(context: vscode.ExtensionContext) {
                 "robotcode.robot.args",
             ]) {
                 if (event.affectsConfiguration(s)) {
-                    vscode.window
+                    await vscode.window
                         .showWarningMessage(
                             'Please use the "Reload Window" action for changes in ' + s + " to take effect.",
                             ...["Reload Window"]