Mark using reserved keywords like "Break", "While",... as errors

Author: d-biehl

CHANGELOG.md

@@ -7,6 +7,7 @@ All notable changes to the "robotcode" extension will be documented in this file
 - Add `dryRun` property to launch configuration
 - Add "Dry Run" and "Dry Debug" profile to test explorer
   - You can select it via Run/Debug dropdown or Right Click on the "green arrow" before the test case/suite or in test explorer and then "Execute Using Profile"
+- Mark using reserved keywords like "Break", "While",... as errors
 
 ##  0.6.0
 

robotcode/language_server/robotframework/diagnostics/analyzer.py

@@ -177,6 +177,13 @@ async def _analyze_keyword_call(
                         severity=DiagnosticSeverity.ERROR,
                         source=DIAGNOSTICS_SOURCE_NAME,
                     )
+                if result.is_reserved():
+                    await self.append_diagnostics(
+                        range=range_from_node_or_token(node, self.strip_bdd_prefix(keyword_token)),
+                        message=f"'{result.name}' is a reserved keyword.",
+                        severity=DiagnosticSeverity.ERROR,
+                        source=DIAGNOSTICS_SOURCE_NAME,
+                    )
 
                 if not isinstance(node, (Template, TestTemplate)):
                     try:

robotcode/language_server/robotframework/diagnostics/library_doc.py

@@ -421,6 +421,9 @@ def signature(self) -> str:
     def parameter_signature(self) -> str:
         return f"({', '.join(str(a) for a in self.args)})"
 
+    def is_reserved(self) -> bool:
+        return self.libname == RESERVED_LIBRARY_NAME
+
     def is_any_run_keyword(self) -> bool:
         return self.libname == BUILTIN_LIBRARY_NAME and self.name in ALL_RUN_KEYWORDS