Skip to content

Commit 965f03e

Browse files
committed
chore: fix some mypyc errors and warnings
1 parent ff5d9ed commit 965f03e

30 files changed

+479
-480
lines changed

robotcode/jsonrpc2/protocol.py

Lines changed: 22 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,6 @@ class ReceivedRequestEntry(NamedTuple):
340340

341341

342342
class JsonRPCProtocolBase(asyncio.Protocol, ABC):
343-
_logger = LoggingDescriptor()
344343
registry: ClassVar = RpcRegistry()
345344

346345
def __init__(self) -> None:
@@ -361,7 +360,6 @@ async def on_connection_made(sender, transport: asyncio.BaseTransport) -> None:
361360
async def on_connection_lost(sender, exc: Optional[BaseException]) -> None:
362361
...
363362

364-
@_logger.call
365363
def connection_made(self, transport: asyncio.BaseTransport) -> None:
366364
super().connection_made(transport)
367365
self._loop = asyncio.get_running_loop()
@@ -372,12 +370,10 @@ def connection_made(self, transport: asyncio.BaseTransport) -> None:
372370

373371
create_sub_task(self.on_connection_made(self, transport))
374372

375-
@_logger.call
376373
def connection_lost(self, exc: Optional[BaseException]) -> None:
377374
create_sub_task(self.on_connection_lost(self, exc))
378375
self._loop = None
379376

380-
@_logger.call
381377
def eof_received(self) -> Optional[bool]:
382378
return False
383379

@@ -422,7 +418,7 @@ def _handle_body(self, body: bytes, charset: str) -> None:
422418

423419

424420
class JsonRPCProtocol(JsonRPCProtocolBase):
425-
_logger = LoggingDescriptor()
421+
__logger = LoggingDescriptor()
426422
_data_logger = LoggingDescriptor(postfix="_data")
427423

428424
def __init__(self) -> None:
@@ -471,7 +467,7 @@ def _handle_body(self, body: bytes, charset: str) -> None:
471467
except (asyncio.CancelledError, SystemExit, KeyboardInterrupt):
472468
raise
473469
except BaseException as e:
474-
self._logger.exception(e)
470+
self.__logger.exception(e)
475471
self.send_error(JsonRPCErrors.PARSE_ERROR, f"{type(e).__name__}: {e}")
476472

477473
def _handle_messages(self, iterator: Iterator[JsonRPCMessage]) -> None:
@@ -485,7 +481,7 @@ def done(f: asyncio.Future[Any]) -> None:
485481
for m in iterator:
486482
create_sub_task(self.handle_message(m)).add_done_callback(done)
487483

488-
@_logger.call
484+
@__logger.call
489485
async def handle_message(self, message: JsonRPCMessage) -> None:
490486
if isinstance(message, JsonRPCRequest):
491487
await self.handle_request(message)
@@ -496,11 +492,11 @@ async def handle_message(self, message: JsonRPCMessage) -> None:
496492
elif isinstance(message, JsonRPCResponse):
497493
await self.handle_response(message)
498494

499-
@_logger.call
495+
@__logger.call
500496
def send_response(self, id: Optional[Union[str, int, None]], result: Optional[Any] = None) -> None:
501497
self.send_message(JsonRPCResponse(id=id, result=result))
502498

503-
@_logger.call
499+
@__logger.call
504500
def send_error(
505501
self,
506502
code: int,
@@ -519,7 +515,7 @@ def send_error(
519515
)
520516
)
521517

522-
@_logger.call
518+
@__logger.call
523519
def send_message(self, message: JsonRPCMessage) -> None:
524520
message.jsonrpc = PROTOCOL_VERSION
525521

@@ -537,7 +533,7 @@ def send_message(self, message: JsonRPCMessage) -> None:
537533
if self._loop:
538534
self._loop.call_soon_threadsafe(self.write_transport.write, msg)
539535

540-
@_logger.call
536+
@__logger.call
541537
def send_request(
542538
self,
543539
method: str,
@@ -564,15 +560,15 @@ async def send_request_async(
564560
) -> Optional[_TResult]:
565561
return await self.send_request(method, params, return_type)
566562

567-
@_logger.call
563+
@__logger.call
568564
def send_notification(self, method: str, params: Any) -> None:
569565
self.send_message(JsonRPCNotification(method=method, params=params))
570566

571-
@_logger.call(exception=True)
567+
@__logger.call(exception=True)
572568
async def handle_response(self, message: JsonRPCResponse) -> None:
573569
if message.id is None:
574570
error = "Invalid response. Response id is null."
575-
self._logger.warning(error)
571+
self.__logger.warning(error)
576572
self.send_error(JsonRPCErrors.INTERNAL_ERROR, error)
577573
return
578574

@@ -581,7 +577,7 @@ async def handle_response(self, message: JsonRPCResponse) -> None:
581577

582578
if entry is None:
583579
error = f"Invalid response. Could not find id '{message.id}' in request list."
584-
self._logger.warning(error)
580+
self.__logger.warning(error)
585581
self.send_error(JsonRPCErrors.INTERNAL_ERROR, error)
586582
return
587583

@@ -614,7 +610,7 @@ def set_result(f: asyncio.Future[Any], r: Any, ev: threading.Event) -> None:
614610
await asyncio.sleep(0)
615611

616612
else:
617-
self._logger.warning(lambda: f"Response {repr(entry)} loop is not running.")
613+
self.__logger.warning(lambda: f"Response {repr(entry)} loop is not running.")
618614

619615
except (SystemExit, KeyboardInterrupt):
620616
raise
@@ -626,7 +622,7 @@ def set_result(f: asyncio.Future[Any], r: Any, ev: threading.Event) -> None:
626622
if entry.future.get_loop().is_running():
627623
entry.future.get_loop().call_soon_threadsafe(entry.future.set_exception, e)
628624

629-
@_logger.call
625+
@__logger.call
630626
async def handle_error(self, message: JsonRPCError) -> None:
631627
raise JsonRPCErrorException(message.error.code, message.error.message, message.error.data)
632628

@@ -717,19 +713,19 @@ def done(t: asyncio.Future[Any]) -> None:
717713
if not t.cancelled():
718714
ex = t.exception()
719715
if ex is not None:
720-
self._logger.exception(ex, exc_info=ex)
716+
self.__logger.exception(ex, exc_info=ex)
721717
raise JsonRPCErrorException(JsonRPCErrors.INTERNAL_ERROR, f"{type(ex).__name__}: {ex}") from ex
722718

723719
self.send_response(message.id, t.result())
724720
except asyncio.CancelledError:
725-
self._logger.debug(lambda: f"request message {repr(message)} canceled")
721+
self.__logger.debug(lambda: f"request message {repr(message)} canceled")
726722
self.send_error(JsonRPCErrors.REQUEST_CANCELLED, "Request canceled.", id=message.id)
727723
except (SystemExit, KeyboardInterrupt):
728724
raise
729725
except JsonRPCErrorException as e:
730726
self.send_error(e.code, e.message or f"{type(e).__name__}: {e}", id=message.id, data=e.data)
731727
except BaseException as e:
732-
self._logger.exception(e)
728+
self.__logger.exception(e)
733729
self.send_error(JsonRPCErrors.INTERNAL_ERROR, f"{type(e).__name__}: {e}", id=message.id)
734730
finally:
735731
with self._received_request_lock:
@@ -739,27 +735,27 @@ def done(t: asyncio.Future[Any]) -> None:
739735

740736
await task
741737

742-
@_logger.call
738+
@__logger.call
743739
def cancel_request(self, id: Union[int, str, None]) -> None:
744740
with self._received_request_lock:
745741
entry = self._received_request.get(id, None)
746742

747743
if entry is not None and entry.future is not None and not entry.future.cancelled():
748-
self._logger.debug(lambda: f"try to cancel request {entry.request if entry is not None else ''}")
744+
self.__logger.debug(lambda: f"try to cancel request {entry.request if entry is not None else ''}")
749745
entry.future.cancel()
750746

751-
@_logger.call
747+
@__logger.call
752748
async def cancel_all_received_request(self) -> None:
753749
for entry in self._received_request.values():
754750
if entry is not None and entry.cancelable and entry.future is not None and not entry.future.cancelled():
755751
entry.future.cancel()
756752

757-
@_logger.call
753+
@__logger.call
758754
async def handle_notification(self, message: JsonRPCNotification) -> None:
759755
e = self.registry.get_entry(message.method)
760756

761757
if e is None or not callable(e.method):
762-
self._logger.warning(lambda: f"Unknown method: {message.method}")
758+
self.__logger.warning(lambda: f"Unknown method: {message.method}")
763759
return
764760
try:
765761
params = self._convert_params(e.method, e.param_type, message.params)
@@ -780,7 +776,7 @@ async def handle_notification(self, message: JsonRPCNotification) -> None:
780776
except (SystemExit, KeyboardInterrupt):
781777
raise
782778
except BaseException as e:
783-
self._logger.exception(e)
779+
self.__logger.exception(e)
784780

785781

786782
TProtocol = TypeVar("TProtocol", bound=JsonRPCProtocol)

0 commit comments

Comments
 (0)