correct completion and signature help for library imports with "WITH NAME"

Author: d-biehl

robotcode/language_server/common/types.py

@@ -856,7 +856,7 @@ def zero() -> "Range":
             ),
         )
 
-    def extended(self, start_line: int, start_character: int, end_line: int, end_character: int) -> Range:
+    def extend(self, start_line: int = 0, start_character: int = 0, end_line: int = 0, end_character: int = 0) -> Range:
         return Range(
             start=Position(line=self.start.line + start_line, character=self.start.character + start_character),
             end=Position(line=self.end.line + end_line, character=self.end.character + end_character),

robotcode/language_server/robotframework/diagnostics/library_doc.py

@@ -886,9 +886,7 @@ def get_test_library(
 
         # skip antigravity easter egg
         # see https://python-history.blogspot.com/2010/06/import-antigravity.html
-        if import_name.lower() in ["antigravity"] or import_name.lower().endswith(
-            ("lib/antigravity.py", f"lib{os.sep}antigravity.py")
-        ):
+        if import_name.lower() in ["antigravity"] or import_name.lower().endswith("antigravity.py"):
             raise IgnoreEasterEggLibraryWarning(f"Ignoring import for python easter egg '{import_name}'.")
 
         errors: List[Error] = []

robotcode/language_server/robotframework/parts/completion.py

@@ -868,9 +868,9 @@ async def complete_LibraryImport(  # noqa: N802
             return []
         import_token_index = import_node.tokens.index(import_token)
 
-        async def complete_import() -> Union[List[CompletionItem], CompletionList, None]:
+        async def complete_import() -> Optional[List[CompletionItem]]:
             if self.document is None:
-                return []
+                return None
 
             if len(import_node.tokens) > import_token_index + 2:
                 name_token = import_node.tokens[import_token_index + 2]
@@ -887,6 +887,9 @@ async def complete_import() -> Union[List[CompletionItem], CompletionList, None]
 
                         if not position.is_in_range(r) and r.end != position:
                             return None
+                    else:
+                        return None
+
             else:
                 return None
 
@@ -954,9 +957,19 @@ async def complete_import() -> Union[List[CompletionItem], CompletionList, None]
                 for e in list
             ]
 
-        async def complete_arguments() -> Union[List[CompletionItem], CompletionList, None]:
+        async def complete_arguments() -> Optional[List[CompletionItem]]:
             if self.document is None:
-                return []
+                return None
+
+            if (
+                import_node.name is None
+                or position <= range_from_token(import_node.get_token(RobotToken.NAME)).extend(end_character=1).end
+            ):
+                return None
+
+            with_name_token = next((v for v in import_node.tokens if v.value == "WITH NAME"), None)
+            if with_name_token is not None and position >= range_from_token(with_name_token).start:
+                return None
 
             if context is None or context.trigger_kind != CompletionTriggerKind.INVOKED:
                 return []
@@ -1063,9 +1076,31 @@ async def complete_arguments() -> Union[List[CompletionItem], CompletionList, No
 
             return None
 
-        result = await complete_import()
-        if not result:
-            result = await complete_arguments()
+        async def complete_with_name() -> Optional[List[CompletionItem]]:
+            if self.document is None:
+                return None
+
+            if context is None or context.trigger_kind != CompletionTriggerKind.INVOKED:
+                return []
+
+            if import_node.name and not any(v for v in import_node.tokens if v.value == "WITH NAME"):
+                name_token = import_node.get_token(RobotToken.NAME)
+                if position >= range_from_token(name_token).extend(end_character=2).end:
+                    return [
+                        CompletionItem(
+                            label="WITH NAME",
+                            kind=CompletionItemKind.TEXT,
+                            # detail=e.detail,
+                            sort_text="03_WITH NAME",
+                            insert_text_format=InsertTextFormat.PLAINTEXT,
+                        )
+                    ]
+            return []
+
+        result = await complete_import() or []
+        result.extend(await complete_arguments() or [])
+        result.extend(await complete_with_name() or [])
+
         return result
 
     async def complete_ResourceImport(  # noqa: N802

robotcode/language_server/robotframework/parts/signature_help.py

@@ -215,7 +215,14 @@ async def signature_help_LibraryImport(  # noqa: N802
 
         library_node = cast(LibraryImport, node)
 
-        if library_node.name is None:
+        if (
+            library_node.name is None
+            or position <= range_from_token(library_node.get_token(RobotToken.NAME)).extend(end_character=1).end
+        ):
+            return None
+
+        with_name_token = next((v for v in library_node.tokens if v.value == "WITH NAME"), None)
+        if with_name_token is not None and position >= range_from_token(with_name_token).start:
             return None
 
         imports_manager = await self.parent.documents_cache.get_imports_manager(document)