refactor: fix some pytest ruff warning

Author: d-biehl

pyproject.toml

@@ -270,7 +270,9 @@ select = [
   "ISC",
   "G",
   #"INP",
-  "PIE"
+  "PIE",
+  # "T20",
+  "PT"
 ]
 
 

tests/robotcode/jsonrpc/test_jsonrpcprotocol.py

@@ -42,7 +42,7 @@ def event_loop() -> Iterator[asyncio.AbstractEventLoop]:
     loop.close()
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_a_request_message_should_work() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -57,7 +57,7 @@ async def test_receive_a_request_message_should_work() -> None:
     assert protocol.handled_messages == [message]
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_a_request_message_should_work_with_string_id() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -72,7 +72,7 @@ async def test_receive_a_request_message_should_work_with_string_id() -> None:
     assert protocol.handled_messages == [message]
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_a_batch_request_should_work() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -91,7 +91,7 @@ async def test_receive_a_batch_request_should_work() -> None:
     assert protocol.handled_messages == message
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_invalid_jsonmessage_should_throw_send_an_error() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -100,13 +100,11 @@ async def test_receive_invalid_jsonmessage_should_throw_send_an_error() -> None:
     data = header + json_message
 
     await protocol.data_received_async(data)
-    assert (
-        isinstance(protocol.sended_message, JsonRPCError)
-        and protocol.sended_message.error.code == JsonRPCErrors.PARSE_ERROR
-    )
+    assert isinstance(protocol.sended_message, JsonRPCError)
+    assert protocol.sended_message.error.code == JsonRPCErrors.PARSE_ERROR
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_a_request_with_invalid_protocol_version_should_send_an_error() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -117,13 +115,11 @@ async def test_receive_a_request_with_invalid_protocol_version_should_send_an_er
     header = f"Content-Length: {len(json_message)}\r\n\r\n".encode("ascii")
     data = header + json_message
     await protocol.data_received_async(data)
-    assert (
-        isinstance(protocol.sended_message, JsonRPCError)
-        and protocol.sended_message.error.code == JsonRPCErrors.PARSE_ERROR
-    )
+    assert isinstance(protocol.sended_message, JsonRPCError)
+    assert protocol.sended_message.error.code == JsonRPCErrors.PARSE_ERROR
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_an_error_should_work() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -136,7 +132,7 @@ async def test_receive_an_error_should_work() -> None:
     assert protocol.handled_messages == [message]
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_response_should_work() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -153,7 +149,7 @@ async def test_receive_response_should_work() -> None:
     assert a == ["dummy", "data"]
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_invalid_id_in_response_should_send_an_error() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -167,7 +163,7 @@ async def test_receive_invalid_id_in_response_should_send_an_error() -> None:
     assert isinstance(protocol.sended_message, JsonRPCError)
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_send_request_receive_response_should_work_without_param_type_work() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -187,7 +183,7 @@ async def test_send_request_receive_response_should_work_without_param_type_work
     assert a == {"title": "hi there"}
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_response_should_work_with_dataclass() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -206,7 +202,7 @@ async def test_receive_response_should_work_with_dataclass() -> None:
     assert a == MessageActionItem(title="hi there")
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_response_should_work_with_generic_list() -> None:
     protocol = DummyJsonRPCProtocol(None)
 
@@ -225,7 +221,7 @@ async def test_receive_response_should_work_with_generic_list() -> None:
     assert a == [MessageActionItem(title="hi there")]
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_receive_response_with_generic_dict_should_return_unchanged() -> None:
     protocol = DummyJsonRPCProtocol(None)
 

tests/robotcode/language_server/common/test_text_document.py

@@ -8,7 +8,7 @@
 from robotcode.utils.async_tools import check_canceled
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_apply_full_change_should_work() -> None:
     text = """first"""
     new_text = """changed"""
@@ -20,7 +20,7 @@ async def test_apply_full_change_should_work() -> None:
     assert document.text() == new_text
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_apply_apply_incremental_change_at_begining_should_work() -> None:
     text = """first"""
     new_text = """changed"""
@@ -34,7 +34,7 @@ async def test_apply_apply_incremental_change_at_begining_should_work() -> None:
     assert document.text() == new_text + text
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_apply_apply_incremental_change_at_end_should_work() -> None:
     text = """first"""
     new_text = """changed"""
@@ -49,7 +49,7 @@ async def test_apply_apply_incremental_change_at_end_should_work() -> None:
     assert document.text() == text + new_text
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_save_and_revert_should_work() -> None:
     text = """first"""
     new_text = """changed"""
@@ -82,7 +82,7 @@ async def test_save_and_revert_should_work() -> None:
     assert document.version == 2
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_apply_apply_incremental_change_in_the_middle_should_work() -> None:
     text = """\
 first line
@@ -104,7 +104,7 @@ async def test_apply_apply_incremental_change_in_the_middle_should_work() -> Non
     assert document.text() == expected
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_apply_apply_incremental_change_with_start_line_eq_len_lines_should_work() -> None:
     text = """\
 first line
@@ -122,7 +122,7 @@ async def test_apply_apply_incremental_change_with_start_line_eq_len_lines_shoul
     assert document.text() == text + new_text
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_apply_apply_incremental_change_with_wrong_range_should_raise_invalidrangerrror() -> None:
     text = """first"""
     new_text = """changed"""
@@ -136,7 +136,7 @@ async def test_apply_apply_incremental_change_with_wrong_range_should_raise_inva
         )
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_apply_none_change_should_work() -> None:
     text = """first"""
 
@@ -148,7 +148,7 @@ async def test_apply_none_change_should_work() -> None:
     assert document.text() == text
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_lines_should_give_the_lines_of_the_document() -> None:
     text = """\
 first
@@ -164,7 +164,7 @@ async def test_lines_should_give_the_lines_of_the_document() -> None:
     assert document.get_lines() == text.splitlines(True)
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_document_get_set_clear_data_should_work() -> None:
     text = """\
 first
@@ -191,7 +191,7 @@ class WeakReferencable:
     assert document.get_data(key, None) is None
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_document_get_set_cache_with_function_should_work() -> None:
     text = """\
 first
@@ -222,7 +222,7 @@ async def get_data(document: TextDocument, data: str) -> str:
     assert await document.get_cache(get_data, "data3") == "3data3"
 
 
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_document_get_set_cache_with_method_should_work() -> None:
     text = """\
 first

tests/robotcode/language_server/robotframework/parts/test_discovering.py

@@ -12,7 +12,7 @@
 
 
 @pytest.mark.usefixtures("protocol")
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_workspace_discovery(
     regtest: RegTestFixture,
     protocol: RobotLanguageServerProtocol,

tests/robotcode/language_server/robotframework/parts/test_document_highlight.py

@@ -25,7 +25,7 @@
     scope="package",
 )
 @pytest.mark.usefixtures("protocol")
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test(
     regtest: RegTestFixture,
     protocol: RobotLanguageServerProtocol,

tests/robotcode/language_server/robotframework/parts/test_foldingrange.py

@@ -62,7 +62,7 @@ def generate_foldingrange_test_id(params: Any) -> Any:
     ids=generate_foldingrange_test_id,
     scope="module",
 )
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test(
     regtest: RegTestFixture,
     protocol: RobotLanguageServerProtocol,

tests/robotcode/language_server/robotframework/parts/test_goto_definition.py

@@ -26,7 +26,7 @@
     scope="module",
 )
 @pytest.mark.usefixtures("protocol")
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_definition(
     regtest: RegTestFixture,
     protocol: RobotLanguageServerProtocol,

tests/robotcode/language_server/robotframework/parts/test_goto_implementation.py

@@ -50,7 +50,7 @@ def split(
     scope="module",
 )
 @pytest.mark.usefixtures("protocol")
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test_implementation(
     regtest: RegTestFixture,
     protocol: RobotLanguageServerProtocol,

tests/robotcode/language_server/robotframework/parts/test_hover.py

@@ -26,7 +26,7 @@
     scope="module",
 )
 @pytest.mark.usefixtures("protocol")
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test(
     regtest: RegTestFixture,
     protocol: RobotLanguageServerProtocol,

tests/robotcode/language_server/robotframework/parts/test_references.py

@@ -29,7 +29,7 @@
     scope="module",
 )
 @pytest.mark.usefixtures("protocol")
-@pytest.mark.asyncio
+@pytest.mark.asyncio()
 async def test(
     regtest: RegTestFixture,
     protocol: RobotLanguageServerProtocol,