Fix crashes when editing Tree items.

Author: HelioGuilherme66

CHANGELOG.adoc

@@ -9,6 +9,7 @@ and this project adheres to http://semver.org/spec/v2.0.0.html[Semantic Versioni
 == https://github.com/robotframework/RIDE[Unreleased]
 
 === Fixed
+- Fixed crash when renaming test cases names on Tree (Project Explorer), by cancelling with Escape or by adding a Space in the end.
 - Fixed  missing text colorization in suites and test settings on Grid Editor.
 
 == https://github.com/robotframework/RIDE/blob/master/doc/releasenotes/ride-2.1.5.2.rst[2.1.5.2] - 2025-07-30

README.adoc

@@ -44,7 +44,7 @@ Likewise, the current version of wxPython, is 4.2.3, but RIDE is known to work w
 
 `pip install -U robotframework-ride`
 
-(3.8 <= python <= 3.14) Install current development version (**2.2dev40**) with:
+(3.8 <= python <= 3.14) Install current development version (**2.2dev41**) with:
 
 `pip install -U https://github.com/robotframework/RIDE/archive/develop.zip`
 

src/robotide/application/CHANGELOG.html

@@ -175,6 +175,8 @@ def set_content(self, html_win, content):
 </ul>
 <p><strong>New Features and Fixes Highlights</strong></p>
 <ul class="simple">
+<li>Fixed crash when renaming test cases names on Tree (Project Explorer), by cancelling with Escape or by adding a Space
+ in the end.</li>
 <li>Fixed missing text colorization in suites and test settings on Grid Editor.</li>
 <li>Restored init and main scripts and texteditor, because some changes in Grid Editor were not being saved in Text 
 Editor and would be lost.</li>
@@ -241,7 +243,7 @@ def set_content(self, html_win, content):
 <pre class="literal-block">python -m robotide.postinstall -install</pre>
 <p>or</p>
 <pre class="literal-block">ride_postinstall.py -install</pre>
-<p>RIDE {VERSION} was released on 14/August/2025.</p>
+<p>RIDE {VERSION} was released on 17/August/2025.</p>
 <!-- <br/>
 <h3>May The Fourth Be With You!</h3>
 <h3>Celebrate the bank holiday, 10th June, Day of Portugal, Portuguese Communities and Camões!!</h3>

src/robotide/application/releasenotes.py

@@ -375,13 +375,15 @@ def _get_undo_command(self):
 class RenameTest(_ReversibleCommand):
 
     def __init__(self, new_name):
-        self._new_name = new_name
+        self._new_name = new_name.strip()
 
     def _params(self):
         return self._new_name
 
     def _execute(self, context):
         old_name = context.name
+        if old_name == self._new_name:
+            return
         context.test_name.rename(self._new_name)
         context.test_name._item.notify_name_changed(old_name=old_name, new_name=self._new_name)
 
@@ -393,7 +395,7 @@ class RenameFile(_Command):
 
     def __init__(self, new_basename):
         self._new_basename = new_basename
-        self._validator = validators.BaseNameValidator(new_basename)
+        self._validator = validators.BaseNameValidator(new_basename.strip())
 
     def execute(self, context):
         validation_result = self._validator.validate(context)
@@ -424,7 +426,7 @@ def execute(self, directory_controller):
 class RenameResourceFile(_Command):
 
     def __init__(self, new_basename, get_should_modify_imports):
-        self._new_basename = new_basename
+        self._new_basename = new_basename.strip()
         self._should_modify_imports = get_should_modify_imports
 
     def execute(self, context):

src/robotide/controller/ctrlcommands.py

@@ -140,6 +140,7 @@ def _get_bind_keys(self):
             (ctrl_or_cmd(), wx.WXK_UP, self._tree.on_move_up),
             (ctrl_or_cmd(), wx.WXK_DOWN, self._tree.on_move_down),
             (wx.ACCEL_NORMAL, wx.WXK_F2, self._tree.label_editor.on_label_edit),
+            (wx.ACCEL_NORMAL, wx.WXK_ESCAPE, self._tree.label_editor.on_label_edited),
             (wx.ACCEL_NORMAL, wx.WXK_WINDOWS_MENU, self._tree.on_right_click),
             (ctrl_or_cmd() | wx.ACCEL_SHIFT, ord('d'), lambda event: self._expanded_handler().on_safe_delete(event)),
             (ctrl_or_cmd() | wx.ACCEL_SHIFT, ord('f'),

src/robotide/controller/ui/treecontroller.py

@@ -198,6 +198,8 @@ def on_include(self, event):
 
 
 class _CanBeRenamed(object):
+    _node = None
+    _old_label = None
 
     def on_rename(self, event):
         __ = event
@@ -206,13 +208,15 @@ def on_rename(self, event):
     def begin_label_edit(self):
         def label_edit():
             # DEBUG: fixme yep.yep.yep.yep.yep
-            node = self._tree.controller.find_node_by_controller(self.controller)
-            if node:
-                self._tree.EditLabel(node)
+            self._node = self._tree.controller.find_node_by_controller(self.controller)
+            if self._node:
+                self._old_label = self._tree.GetItemText(self._node)
+                self._tree.EditLabel(self._node)
         # Must handle pending events before label edit
         # This is a fix for situations where there is a pending action
         # that will change this label (Text Editor all changing actions)
-        wx.CallAfter(label_edit)
+        # wx.CallAfter(label_edit)
+        label_edit()
         return True
 
     def end_label_edit(self, event):
@@ -221,6 +225,11 @@ def end_label_edit(self, event):
                 self.rename(event.GetLabel())
             else:
                 event.Veto()
+        else:
+            self._set_node_label(self._old_label)
+
+    def _set_node_label(self, label):
+        self._tree.SetItemText(self._node, label)
 
     def _is_valid_rename(self, label):
         validation = self.controller.validate_name(label)

src/robotide/ui/treenodehandlers.py

@@ -20,7 +20,7 @@
 from wx import Colour, Point
 from wx.lib.agw import customtreectrl
 from wx.lib.agw.aui import GetManager
-from wx.lib.agw.customtreectrl import GenericTreeItem
+from wx.lib.agw.customtreectrl import GenericTreeItem, TreeEvent
 from wx.lib.mixins import treemixin
 
 from ..context import IS_WINDOWS
@@ -1285,9 +1285,12 @@ def on_label_edit(self, event=None):
                 self._editing_label = False
 
     def on_label_edited(self, event):
+        if not self._editing_label:
+            return
         self._editing_label = False
         self._on_label_edit_called = False
-        self._tree.controller.get_handler(event.GetItem()).end_label_edit(event)
+        if isinstance(event, TreeEvent):
+            self._tree.controller.get_handler(event.GetItem()).end_label_edit(event)
 
         # Reset edit control as it doesn't seem to reset it in case the focus
         # goes directly away from the tree control
@@ -1300,7 +1303,7 @@ def on_label_edited(self, event):
 
     def _stop_editing(self):
         control = self._tree.GetEditControl()
-        if control and wx.Window.FindFocus():
+        if control:  # and wx.Window.FindFocus():
             control.StopEditing()
 
     def on_delete(self, event):

src/robotide/ui/treeplugin.py

@@ -15,4 +15,4 @@
 #
 # Automatically generated by `tasks.py`.
 
-VERSION = 'v2.2dev40'
+VERSION = 'v2.2dev41'