Cleaning (#2556)

* Reduce warnings in utest

* Dev version

Author: HelioGuilherme66

src/robotide/action/actioninfo.py

@@ -254,6 +254,7 @@ def position(self):
                 return int(self._position.split("POSITION-")[-1])
         return -1
 
+
 class SeparatorInfo(MenuInfo):
     """Used to create separators to menus."""
 
@@ -273,7 +274,7 @@ def is_separator(self):
 
 
 class _InsertionPoint(object):
-    _shortcut_remover = re.compile(' {2,}\([^()]+\)$')
+    _shortcut_remover = re.compile(r" {2,}\([^()]+\)$")
 
     def __init__(self, before=None, after=None):
         self._item = before or after

src/robotide/contrib/testrunner/usages.py

@@ -19,7 +19,7 @@
     try:
         from robotide.lib.robot.run import USAGE  # Then try the provided version, 3.1.2
     except ImportError:
-        USAGE = """\
+        USAGE = """
 Robot Framework -- A generic test automation framework
 
 Usage:  robot|jybot|irobot [options] data_sources
@@ -313,7 +313,7 @@
                           all given arguments, incl. data sources, are escaped
                           so escape characters ought to be selected carefully.
                           Available escapes: amp (&), apos ('), at (@), bslash
-                          (\), colon (:), comma (,), curly1 ({), curly2 (}),
+                          (\\), colon (:), comma (,), curly1 ({), curly2 (}),
                           dollar ($), exclam (!), gt (>), hash (#), lt (<),
                           paren1 ((), paren2 ()), percent (%), pipe (|), quest
                           (?), quot ("), semic (;), slash (/), space ( ),

src/robotide/controller/filecontrollers.py

@@ -400,6 +400,7 @@ def is_inside_top_suite(self, res):
 
 
 class TestDataDirectoryController(_DataController, _FileSystemElement, _BaseController):
+    __test__ = False
 
     def __init__(self, data, project=None, parent=None):
         dir_ = data.directory
@@ -684,6 +685,7 @@ class DirtyRobotDataException(Exception):
 
 
 class TestCaseFileController(_FileSystemElement, _DataController):
+    __test__ = False
 
     def __init__(self, data, project=None, parent=None):
         _FileSystemElement.__init__(self, data.source if data else None, data.directory)

src/robotide/controller/macrocontrollers.py

@@ -70,6 +70,7 @@ class KeywordNameController(ItemNameController):
 
 
 class TestCaseNameController(ItemNameController):
+    __test__ = False
     _name_field = TESTCASE_NAME_FIELD
 
 
@@ -308,6 +309,7 @@ def _notify(self, messageclass):
 
 
 class TestCaseController(_WithStepsController):
+    __test__ = False
 
     _populator = robotapi.TestCasePopulator
     filename = ""

src/robotide/controller/tablecontrollers.py

@@ -24,7 +24,7 @@
 from .settingcontrollers import MetadataController, ImportController, VariableController
 
 
-class _WithListOperations(object):
+class WithListOperations(object):
 
     def move_up(self, index):
         if index > 0:
@@ -72,7 +72,7 @@ def _index_difference(self, original_list, sorted_list):
         return index_difference
 
 
-class VariableTableController(_TableController, _WithListOperations):
+class VariableTableController(_TableController, WithListOperations):
 
     def __init__(self, parent_controller, table):
         _TableController.__init__(self, parent_controller, table)
@@ -100,7 +100,7 @@ def move_up(self, index):
         if index == 0:
             return False
         ctrl = self[index]
-        _WithListOperations.move_up(self, index)
+        WithListOperations.move_up(self, index)
         other = self[index]
         self.mark_dirty()
         RideVariableMovedUp(item=ctrl, other=other).publish()
@@ -109,7 +109,7 @@ def move_down(self, index):
         if index + 1 == len(self._items):
             return False
         ctrl = self[index]
-        _WithListOperations.move_down(self, index)
+        WithListOperations.move_down(self, index)
         other = self[index]
         self.mark_dirty()
         RideVariableMovedDown(item=ctrl, other=other).publish()
@@ -316,6 +316,7 @@ def _configure_controller(self, ctrl, config):
 
 
 class TestCaseTableController(_MacroTable):
+    __test__ = False
     item_type = 'Test case'
     _controller_class = macrocontrollers.TestCaseController
 
@@ -385,7 +386,7 @@ def restore_keyword_order(self, list):
         self._table.keywords = keywords_temp
 
 
-class ImportSettingsController(_TableController, _WithListOperations):
+class ImportSettingsController(_TableController, WithListOperations):
 
     def __init__(self, parent_controller, table, resource_file_controller_factory=None):
         _TableController.__init__(self, parent_controller, table)
@@ -415,18 +416,18 @@ def _items(self):
     def resource_file_controller_factory(self):
         return self._resource_file_controller_factory
 
-    @overrides(_WithListOperations)
+    @overrides(WithListOperations)
     def _swap(self, ind1, ind2):
         imps = self._import_controllers
         imps[ind1], imps[ind2] = imps[ind2], imps[ind1]
-        _WithListOperations._swap(self, ind1, ind2)
+        WithListOperations._swap(self, ind1, ind2)
 
     def remove_import_data(self, imp):
         self.delete(self._items.data.index(imp))
 
     def delete(self, index):
         item = self[index]
-        _WithListOperations.delete(self, index)
+        WithListOperations.delete(self, index)
         self._import_controllers.pop(index)
         item.publish_removed()
         self.notify_imports_modified()
@@ -469,7 +470,7 @@ def resource_import_modified(self, path):
         return self._parent.resource_import_modified(path)
 
 
-class MetadataListController(_TableController, _WithListOperations):
+class MetadataListController(_TableController, WithListOperations):
 
     def __iter__(self):
         return iter(MetadataController(self, m) for m in self._items)

src/robotide/controller/testexecutionresults.py

@@ -18,6 +18,7 @@
 
 
 class TestExecutionResults(object):
+    __test__ = False
     RUNNING = 'Running'
     STOPPED = 'Stopped'
     PASSED = 'Passed'

src/robotide/controller/ui/treecontroller.py

@@ -49,21 +49,25 @@ def register_tree_actions(self):
                                                            action=self.OnClearSelected))
 
     def OnGoBack(self, event):
+        _ = event
         node = self._history.back()
         if node:
             self._tree.SelectItem(node)
 
     def OnAddTagToSelected(self, event):
+        _ = event
         if self._test_selection.is_empty():
             return
         name = wx.GetTextFromUser(message='Enter Tag Name', caption='Add Tag To Selected')
         if name:
             self._test_selection.add_tag(name)
 
     def OnClearSelected(self, event):
+        _ = event
         self._test_selection.clear_all(message=None)
 
     def OnGoForward(self, event):
+        _ = event
         node = self._history.forward()
         if node:
             self._tree.SelectItem(node)
@@ -181,6 +185,7 @@ def clear(self):
 
 
 class TestSelectionController(object):
+    __test__ = False
 
     def __init__(self):
         self._tests: {TestCaseController} = set()
@@ -192,6 +197,7 @@ def is_test_selected(self, test):
         return test in self._tests
 
     def clear_all(self, message):
+        _ = message
         self._tests = set()
         self._send_selection_changed_message()
 
@@ -241,5 +247,6 @@ def _move_default_tags_to_test(self, test):
             if isinstance(tag, DefaultTag):
                 self._add_tag(test, tag.name)
 
-    def _add_tag(self, test, name):
+    @staticmethod
+    def _add_tag(test, name):
         test.tags.execute(ctrlcommands.ChangeTag(Tag(None), name))

src/robotide/editor/dialoghelps.py

@@ -20,17 +20,18 @@ def get_help(title):
 
 _HELPS = {}
 _EXAMPLES = {
-'ESCAPE': "Possible pipes in the value must be escaped with a backslash like '\|'.",
-'TAG': "Separate tags with a pipe character like 'tag | second tag | 3rd'.",
-'FIXTURE': "Separate possible arguments with a pipe character like 'My Keyword | arg 1 | arg 2'.",
-'TIMEOUT': ("Use time syntax like '1min 10s' or '2 hours' or give the value as seconds.\n"
-            "Optional message can be specified like '3 minutes | My message here'."),
-'ARGUMENTS': ("Specify the arguments separated with a pipe character like '${arg1} | ${arg2}'.\n"
-              "Default values are given using equal sign and the last argument can be a list variable.\n"
-              "Example: '${arg1} | ${arg2}=default value | @{rest}'.\n"
-              "Note. You can use variable shortcuts in this field.")
+    'ESCAPE': "Possible pipes in the value must be escaped with a backslash like '\\|'.",
+    'TAG': "Separate tags with a pipe character like 'tag | second tag | 3rd'.",
+    'FIXTURE': "Separate possible arguments with a pipe character like 'My Keyword | arg 1 | arg 2'.",
+    'TIMEOUT': ("Use time syntax like '1min 10s' or '2 hours' or give the value as seconds.\n"
+                "Optional message can be specified like '3 minutes | My message here'."),
+    'ARGUMENTS': ("Specify the arguments separated with a pipe character like '${arg1} | ${arg2}'.\n"
+                  "Default values are given using equal sign and the last argument can be a list variable.\n"
+                  "Example: '${arg1} | ${arg2}=default value | @{rest}'.\n"
+                  "Note. You can use variable shortcuts in this field.")
 }
 
+current = None
 for row in """
 Scalar Variable
 Give name and value of the variable.

src/robotide/editor/editordialogs.py

@@ -60,7 +60,7 @@ def _add_comment_editor(self, item):
         self._sizer.Add(self._comment_editor)
 
     def _create_line(self):
-        line = wx.StaticLine(self, size=(20,-1), style=wx.LI_HORIZONTAL)
+        line = wx.StaticLine(self, size=(20, -1), style=wx.LI_HORIZONTAL)
         if wx.VERSION < (4, 1, 0):
             self._sizer.Add(line, 0, wx.GROW | wx.ALIGN_CENTER_VERTICAL | wx.RIGHT | wx.TOP, 5)
         else:
@@ -71,7 +71,7 @@ def _create_help(self):
                         flag=wx.ALL, border=2)
 
     def _create_buttons(self, **kwargs):
-        buttons = self.CreateStdDialogButtonSizer(wx.OK|wx.CANCEL)
+        buttons = self.CreateStdDialogButtonSizer(wx.OK | wx.CANCEL)
         self.SetBackgroundColour(Colour(self.color_background))
         self.SetForegroundColour(Colour(self.color_foreground))
         for item in self.GetChildren():
@@ -80,10 +80,10 @@ def _create_buttons(self, **kwargs):
                 item.SetOwnBackgroundColour(Colour(self.color_secondary_background))
                 item.SetForegroundColour(Colour(self.color_secondary_foreground))
                 item.SetOwnForegroundColour(Colour(self.color_secondary_foreground))
-        self._sizer.Add(buttons, 0, wx.ALIGN_CENTER|wx.ALL, 5)
+        self._sizer.Add(buttons, 0, wx.ALIGN_CENTER | wx.ALL, 5)
 
     def get_value(self):
-        return [ e.get_value() for e in self._editors ]
+        return [e.get_value() for e in self._editors]
 
     def get_comment(self):
         return self._comment_editor.get_value()
@@ -251,11 +251,15 @@ def _execute(self):
 
 
 class TestSetupDialog(_FixtureDialog):
+    __test__ = False
+
     def _execute(self):
         pass
 
 
 class TestTeardownDialog(_FixtureDialog):
+    __test__ = False
+
     def _execute(self):
         pass
 
@@ -276,6 +280,8 @@ def _execute(self):
 
 
 class TestTemplateDialog(_FixtureDialog):
+    __test__ = False
+
     def _execute(self):
         pass
 
@@ -294,6 +300,7 @@ def _execute(self):
 
 
 class TestTimeoutDialog(_SettingDialog):
+    __test__ = False
     _validator = TimeoutValidator
 
     def _execute(self):
@@ -317,6 +324,7 @@ def _execute(self):
 
 
 class TestCaseNameDialog(_Dialog):
+    __test__ = False
     _title = 'New Test Case'
 
     def _add_comment_editor(self, item):

src/robotide/editor/editors.py

@@ -90,6 +90,7 @@ def __init__(self, plugin, parent, controller, tree):
                            0, wx.EXPAND | wx.ALL, 5)
             # self.sizer.Add((0, 10))  # DEBUG why this?
         self._editors = []
+        self._last_shown_tooltip = None
         self._reset_last_show_tooltip()
         self._populate()
         self.plugin.subscribe(self._settings_changed, RideItemSettingsChanged)
@@ -109,6 +110,7 @@ def _settings_changed(self, message):
                 editor.update_value()
 
     def OnIdle(self, event):
+        _ = event
         if self._last_shown_tooltip and self._mouse_outside_tooltip():
             self._last_shown_tooltip.hide()
             self._reset_last_show_tooltip()
@@ -247,7 +249,8 @@ def create_editor_for(self, controller, plugin, tree):
         editor_cls = self._get_editor_class(controller)
         return editor_cls(self.GetPane(), controller, plugin, tree)
 
-    def _get_editor_class(self, controller):
+    @staticmethod
+    def _get_editor_class(controller):
         if isinstance(controller, DocumentationController):
             return DocumentationEditor
         if isinstance(controller, TagsController):
@@ -300,9 +303,11 @@ def __init__(self, *args):
             self._update_source_and_name, RideFileNameChanged)
 
     def _update_source(self, message=None):
+        _ = message
         self._source.SetValue(self.controller.data.source)
 
     def _update_source_and_name(self, message):
+        _ = message
         self._title_display.SetLabel(self.controller.name)
         self._update_source()
 
@@ -377,13 +382,15 @@ def _create_header(self, text, readonly=False):
             text += ' (READ ONLY)'
 
         def cb(event):
+            _ = event
             ResourceFileUsages(self.controller, self._tree.highlight).show()
         self._title_display = FindUsagesHeader(self, text, cb, color_foreground=self.color_secondary_foreground,
                                                color_background=self.color_secondary_background)
         return self._title_display
 
 
 class TestCaseFileEditor(_FileEditor):
+    __test__ = False
     _settings_open_id = 'test case file settings open'
 
     def _populate(self):
@@ -405,6 +412,7 @@ def _populate(self):
         self.plugin.subscribe(self._init_file_removed, RideInitFileRemoved)
 
     def _init_file_removed(self, message):
+        _ = message
         for setting, editor in zip(self.controller.settings, self._editors):
             editor.refresh(setting)