Improve utests (#2943)

* Improve utests

* Update utests. Keep coverage.xml

Author: HelioGuilherme66

.github/workflows/fedora_41.yml

@@ -93,7 +93,7 @@ jobs:
     - uses: actions/upload-artifact@v4
       with:
         name: coverage-report
-        path: .coverage-reports/htmlcov
+        path: .coverage-reports/
     - name: Install and run
       run: |
         git submodule update --init --recursive

.github/workflows/linux.yml

@@ -128,7 +128,7 @@ jobs:
     - uses: actions/upload-artifact@v4
       with:
         name: coverage-report
-        path: .coverage-reports/htmlcov/
+        path: .coverage-reports/
     - name: Install and run
       run: |
         git submodule update --init --recursive

pytest.ini

@@ -1,3 +1,4 @@
 [pytest]
 addopts = -p no:warnings --order-group-scope=module
 pythonpath = src src/robotide/preferences/configobj/src
+

utest/application/test_editor_provider.py

@@ -39,7 +39,7 @@ def test_registering(self):
         self.p.register_editor(TestObject, TestEditor2)
         assert self.p.get_editor(TestObject) == TestEditor2
 
-    def test_setting_deafult_editor(self):
+    def test_setting_default_editor(self):
         self.p.register_editor(TestObject, TestEditor2, default=False)
         assert self.p.get_editor(TestObject) == TestEditor
 
@@ -61,6 +61,11 @@ def test_registering_twice_does_nothing(self):
         self.p.register_editor(TestObject, TestEditor)
         assert self.p.get_editors(TestObject) == [TestEditor]
 
+    def test_set_default_last_does_nothing(self):
+        self.p.register_editor(TestObject, TestEditor)
+        self.p._editors[TestObject].set_default(TestEditor)
+        assert self.p._editors[TestObject].get() == TestEditor
+
     def test_activating(self):
         self.p.register_editor(TestObject, TestEditor2, default=False)
         self.p.set_active_editor(TestObject, TestEditor2)

utest/controller/test_commands.py

@@ -18,6 +18,7 @@
 import unittest
 from robotide.controller.tags import DefaultTag
 from robotide.controller.ctrlcommands import *
+from robotide.editor.formatters import ListToStringFormatter
 
 # Workaround for relative import in non-module
 # see https://stackoverflow.com/questions/16981921/relative-imports-in-python-3
@@ -553,6 +554,11 @@ def test_commenting_and_uncommenting_row_with_no_step(self):
         self._exec(uncomment_rows([10001]))
         self._verify_number_of_test_changes(0)
 
+    def test_formatter(self):
+        data = self._steps[self._data_row(FOR_LOOP_HEADER)]
+        formatted = ListToStringFormatter(data).value
+        assert formatted == "FOR | ${i} | IN | 1 | 2 | 3"
+
 
 _TEST_WITH_TWO_FOR_LOOPS = ['Test With Two For Loops',
                             '  FOR  ${i}  IN  1  2',

utest/controller/test_controllers.py

@@ -17,6 +17,9 @@
 import os
 import sys
 import unittest
+from copy import deepcopy
+
+import pytest
 from mockito import mock
 from robotide.robotapi import ALIAS_MARKER
 
@@ -30,6 +33,7 @@
 from robotide.controller.tablecontrollers import (
     VariableTableController, MetadataListController, ImportSettingsController,
     WithListOperations)
+from robotide.controller.settingcontrollers import MetadataController
 from robotide.publish.messages import (
     RideImportSetting, RideImportSettingRemoved, RideImportSettingAdded,
     RideImportSettingChanged, RideItemSettingsChanged)
@@ -497,6 +501,33 @@ def test_editing(self):
         self._assert_var_in_ctrl(1, '@{listvar}', ['a', 'b', 'c'])
         assert self.ctrl.dirty
 
+    def test_index_difference(self):
+        import operator
+        self.ctrl.add_variable('${blaa}', 'value')
+        names = [n for n in self.ctrl]  # [n for n in self.ctrl]
+        ordered = deepcopy(names)
+        ordered = sorted(ordered, key=operator.attrgetter('name'))
+        diff = self.ctrl._index_difference(names, ordered)
+        print(f"DEBUG: test_controllers.py VariablesControllerTest test_index_difference diff={diff}")
+        assert diff == [1, 2, 0]
+
+    def test_validate_name(self):
+        first = self.ctrl.validate_dict_variable_name('%{boo}') #  validate_name
+        # print(f"DEBUG: test_controllers.py VariablesControllerTest test_validate_name first={first.error_message}")
+        assert first.error_message == "Dictionary variable name must be in format &{name}"
+        self._add_var('&{foo}', 'boo')
+        second = self.ctrl.validate_dict_variable_name('&{foo}')  # validate_name
+        # print(f"DEBUG: test_controllers.py VariablesControllerTest test_validate_name first={second.error_message}")
+        assert second.error_message == "Variable with this name already exists."
+
+    def test_delete_var(self):
+        self._add_var('${boo}', 'boo')
+        existing = [x.name for x in self.ctrl]
+        assert existing == ['${foo}', '@{bar}', '${boo}']
+        self.ctrl.delete(-1)
+        existing = [x.name for x in self.ctrl]
+        assert existing == ['${foo}', '@{bar}']
+
     def _assert_var_in_ctrl(self, index, name, value):
         assert self.ctrl[index].name == name
         assert self.ctrl[index].value == value
@@ -525,6 +556,14 @@ def test_editing(self):
     def test_serialization(self):
         assert (self._get_metadata(0).as_list() == ['Metadata', 'Meta name', 'Some value'])
 
+    def test_iter_metadatalist(self):
+        for item in self.ctrl:
+            assert isinstance(item, MetadataController)
+
+    def test_add_metadata(self):
+        self.ctrl.add_metadata('test_metadata', 'this is the value', 'this is the comment')
+        self._assert_meta_in_model(-1, 'test_metadata', 'this is the value')
+
     def _assert_meta_in_ctrl(self, index, name, value):
         assert self.ctrl[index].name == name
         assert self.ctrl[index].value == value
@@ -550,6 +589,13 @@ def _items(self):
     def mark_dirty(self):
         self.dirty = True
 
+    @property
+    def original_items(self):
+        return WithListOperations()._items
+
+    def original_mark_dirty(self):
+        WithListOperations.mark_dirty(self)
+
 
 class WithListOperationsTest(unittest.TestCase):
 
@@ -582,6 +628,16 @@ def test_delete(self):
         self._list_operations.delete(0)
         self._assert_item_in(0, 'bar')
 
+    def test_original_items(self):
+        with pytest.raises(NotImplementedError):
+            items = self._list_operations.original_items
+            print(f"DEBUG: test_controllers WithListOperationsTests test_original_items items={items}")
+
+    def test_original_mark_dirty(self):
+        with pytest.raises(NotImplementedError):
+            self._list_operations.original_mark_dirty()
+            print("DEBUG: test_controllers WithListOperationsTests test_original_mark_dirty")
+
     def _assert_item_in(self, index, name):
         assert self._list_operations._items[index] == name
 

utest/editor/test_z_kweditor_plugin.py

@@ -530,6 +530,11 @@ def test_contentassist_file_button(self):
         wx.CallLater(5000, self.app.ExitMainLoop)
         self.app.MainLoop()
 
+    def test_get_resources(self):
+        res = self.creator._only_resource_files(self.frame.tree)
+        print(f"DEBUG: test_edit_creator.py EditorCreatorTest test_get_resources res={res}")
+
+
 
 if __name__ == '__main__':
     unittest.main()

utest/namespace/test_namespace.py

@@ -7,6 +7,7 @@
     TestCaseFile, Resource, VariableTable, TestDataDirectory)
 from robotide.context import IS_WINDOWS
 from robotide.namespace.namespace import _VariableStash
+from robotide.controller.basecontroller import WithNamespace
 from robotide.controller.filecontrollers import data_controller
 from robotide.spec.iteminfo import ArgumentInfo, VariableInfo
 from robotide.spec.librarymanager import LibraryManager
@@ -110,6 +111,12 @@ def tearDownClass(cls):
 
 class TestKeywordSuggestions(_DataFileTest):
 
+    def test_get_cached_lib_names(self):
+        project = WithNamespace()
+        project._set_namespace(self.ns)
+        lib_names = project.get_all_cached_library_names()
+        assert lib_names == []
+
     def test_getting_suggestions_for_empty_datafile(self):
         start = 'shOulD'
         # print("DEBUG: %s kw %s\n" % (start, self.kw.__doc__))

utest/namespace/test_resourcefactory.py

@@ -63,7 +63,7 @@ def test_resourcefactory_ignores_imported_resource_from_ignore_directory(
 
     def test_resourcefactory_ignores_imported_resource_from_ignore_subdirectory(self):
         self.r = self._create_factory(os.path.split(os.path.dirname(__file__))[0])
-        self.assertEqual(None, self.r.get_resource_from_import(self._import, self._context))
+        self.assertIsNone(self.r.get_resource_from_import(self._import, self._context))
 
     def test_resourcefactory_finds_imported_resource_when_subdirectory_ignored(self):
         self.r = self._create_factory(os.path.join(os.path.dirname(__file__), 'something'))
@@ -77,7 +77,7 @@ def test_resourcefactory_finds_imported_resource_when_similar_ignore_name(self):
     def test_resourcefactory_ignores_imported_resource_when_relative_import(self):
         self.r = self._create_factory(os.path.abspath('.'))
         imp = ImportSetting(None, os.path.join('.', 'foo'))
-        self.assertEqual(None, self.r.get_resource_from_import(imp, self._context))
+        self.assertIsNone(self.r.get_resource_from_import(imp, self._context))
 
     def test_resourcefactory_finds_imported_resource_from_python_path(self):
         self.r = _ResourceFactory(FakeSettings())
@@ -87,7 +87,14 @@ def test_resourcefactory_finds_imported_resource_from_python_path(self):
     def test_resourcefactory_ignores_imported_resource_from_python_path(self):
         self.r = self._create_factory(os.path.dirname(__file__))
         self.r.from_path = os.path.dirname(__file__)
-        self.assertEqual(None, self.r.get_resource_from_import(self._import, self._context))
+        self.assertIsNone(self.r.get_resource_from_import(self._import, self._context))
+
+    def test_resourcefactory_with_separator(self):
+        self.r = self._create_factory(os.path.dirname(__file__))
+        self.r.from_path = os.path.dirname(__file__)
+        dir_name = self.r._with_separator(self.r.from_path)
+        last_char = dir_name[-1]
+        assert last_char == os.path.sep
 
     if IS_WINDOWS:
 
@@ -102,7 +109,7 @@ def test_case_insensitive_ignore_relative_with_pattern(self):
 
     def _ignore_import(self, exclude_directory):
         self.r = self._create_factory(exclude_directory)
-        self.assertEqual(None, self.r.get_resource_from_import(self._import, self._context))
+        self.assertIsNone(self.r.get_resource_from_import(self._import, self._context))
 
     def _create_factory(self, excluded_dir):
         settings = FakeSettings()
@@ -120,7 +127,7 @@ def _mock_context(self):
 
     def _is_resolved(self, factory, imp=None):
         imp = imp or self._import
-        self.assertNotEqual(None, factory.get_resource_from_import(imp, self._context))
+        self.assertIsNotNone(factory.get_resource_from_import(imp, self._context))
 
 
 if __name__ == '__main__':

utest/publish/test_message_publishing.py

@@ -19,6 +19,7 @@
 from robotide.publish.messages import (RideMessage, RideLogMessage,
                                        RideLogException)
 from robotide.publish.publisher import PUBLISHER
+from robotide.publish import get_html_message
 
 
 class RideTestMessage(RideMessage):
@@ -53,6 +54,10 @@ class RideNoneTopicTestMessage(RideTestMessage):
 
 class TestMessage(unittest.TestCase):
 
+    def test_no_robot_message(self):
+        message = get_html_message('no_robot')
+        assert 'Robot Framework installation not found!' in message
+
     def test_topic(self):
         assert RideMessage.topic() == 'ride'
         assert RideTestMessage.topic() == 'my.topic'