Improved vertical scroll in Grid Editor (#2957)

* Remove always show scrollbars

* Improved vertical scroll in Grid Editor

Author: HelioGuilherme66

CHANGELOG.adoc

@@ -18,6 +18,7 @@ and this project adheres to http://semver.org/spec/v2.0.0.html[Semantic Versioni
 when selecting in Tree shows the filename in StatusBar.
 
 === Changed
+- Improved vertical scroll in Grid Editor, by having main scroll bars out of cells
 - Changed arguments parser to allow ``--version`` and ``--help`` functional in Windows
 - Improved auto-complete in Grid Editor, to allow several matches
 - Changed some informative dialogs and JSON Editor to use the customized colors.

README.adoc

@@ -41,7 +41,7 @@ Likewise, the current version of wxPython, is 4.2.3, but RIDE is known to work w
 
 `pip install -U robotframework-ride`
 
-(3.8 <= python <= 3.13) Install current development version (**2.2dev28**) with:
+(3.8 <= python <= 3.13) Install current development version (**2.2dev29**) with:
 
 `pip install -U https://github.com/robotframework/RIDE/archive/develop.zip`
 

src/robotide/application/CHANGELOG.html

@@ -14,6 +14,8 @@
 Added divided Status Bar. Left side for main window, right side for Plugins. Working example in Text Editor,
 when selecting in Tree shows the filename in StatusBar.
 </li></ul></div></div><div class="section"><div class="titlepage"><div><div><h3 class="title"><a id="_changed"></a>1.2. Changed</h3></div></div></div><div class="itemizedlist"><ul class="itemizedlist" style="list-style-type: disc; "><li class="listitem">
+Improved vertical scroll in Grid Editor, by having main scroll bars out of cells
+</li><li class="listitem">
 Changed arguments parser to allow ``--version`` and ``--help`` functional in Windows
 </li><li class="listitem">
 Improved auto-complete in Grid Editor, to allow several matches

src/robotide/application/releasenotes.py

@@ -172,6 +172,7 @@ def set_content(self, html_win, content):
 </ul>
 <p><strong>New Features and Fixes Highlights</strong></p>
 <ul class="simple">
+<li>Improved vertical scroll in Grid Editor, by having main scroll bars out of cells.</li> 
 <li>Fixed Create Desktop Shortcut by pointing executable to <b>python -m robotide</b>.</li>
 <li>Changed arguments parser to allow <b>--version</b> and <b>--help</b> functional in Windows.</li>
 <li>Improved auto-complete in Grid Editor, to allow several matches.</li>
@@ -240,7 +241,7 @@ def set_content(self, html_win, content):
 <pre class="literal-block">python -m robotide.postinstall -install</pre>
 <p>or</p>
 <pre class="literal-block">ride_postinstall.py -install</pre>
-<p>RIDE {VERSION} was released on 25/May/2025.</p>
+<p>RIDE {VERSION} was released on 28/May/2025.</p>
 <!-- <br/>
 <h3>May The Fourth Be With You!</h3>
 <h3>Celebrate the bank holiday, 10th June, Day of Portugal, Portuguese Communities and Camões!!</h3>

src/robotide/editor/__init__.py

@@ -193,10 +193,10 @@ def on_file_deleted(self, message):
         self._create_editor()
 
 
-class _EditorTab(wx.Panel):
+class _EditorTab(wx.ScrolledWindow):
 
     def __init__(self, plugin):
-        wx.Panel.__init__(self, plugin.notebook, style=wx.SUNKEN_BORDER)
+        wx.ScrolledWindow.__init__(self, plugin.notebook, style=wx.SUNKEN_BORDER)
         self.plugin = plugin
         self.sizer = wx.BoxSizer(wx.VERTICAL)
         self.SetSizer(self.sizer)

src/robotide/editor/editors.py

@@ -60,7 +60,7 @@ class EditorPanel(wx.lib.scrolledpanel.ScrolledPanel):
         = show_content_assist = lambda self: None
 
     def __init__(self, plugin, parent, controller, tree):
-        wx.lib.scrolledpanel.ScrolledPanel.__init__(self, parent, style=wx.HSCROLL|wx.VSCROLL|wx.ALWAYS_SHOW_SB)
+        wx.lib.scrolledpanel.ScrolledPanel.__init__(self, parent, style=wx.HSCROLL|wx.VSCROLL)
         from ..preferences import RideSettings
         _settings = RideSettings()
         self.general_settings = _settings['General']
@@ -98,6 +98,7 @@ def __init__(self, plugin, parent, controller, tree):
         self.sizer = wx.BoxSizer(wx.VERTICAL)
         self.Bind(wx.EVT_IDLE, self.on_idle)
         self.SetSizer(self.sizer)
+        self.SetupScrolling()
         if self.title:
             self.sizer.Add(self._create_header(self.title),
                            0, wx.EXPAND | wx.ALL, 6)
@@ -189,8 +190,10 @@ def _restore_settings_open_status(self):
     def _collabsible_changed(self, event=None):
         self._store_settings_open_status()
         self.GetSizer().Layout()
+        self.EnableScrolling(True, True)
         self.Refresh()
         self.Parent.GetSizer().Layout()
+        self.Parent.EnableScrolling(True, True)
         self.Parent.Refresh()
         if event:
             event.Skip()

src/robotide/editor/kweditor.py

@@ -15,6 +15,7 @@
 
 import builtins
 import json
+from typing import Iterable
 from json.decoder import JSONDecodeError
 from multiprocessing import shared_memory
 
@@ -91,7 +92,8 @@ def __init__(self, parent, controller, tree):
         self.color_background_help = self.general_settings['background help']
         self.color_foreground_text = self.general_settings['foreground text']
         GridEditor.__init__(self, parent, len(controller.steps) + 5, max((controller.max_columns + 1), 5),
-                            parent.plugin.grid_popup_creator)
+                                         parent.plugin.grid_popup_creator)
+        self._grid = self.GetGridWindow()
         self._popup_items = ([
                              _('Insert Cells\tCtrl-Shift-I'), _('Delete Cells\tCtrl-Shift-D'),
                              _(INS_ROWS), _(DEL_ROWS), '---',
@@ -192,10 +194,10 @@ def __init__(self, parent, controller, tree):
         self._namespace_updated = None
         self.InheritAttributes()
         self.col_label_element = None
-        if hasattr(self, 'SetupScrolling'):
-            self.SetupScrolling(scrollToTop=True, scrollIntoView=True)
-            self.ShowScrollbars(wx.SHOW_SB_ALWAYS, wx.SHOW_SB_ALWAYS)
-            print("DEBUG: GridBase init at SELF SetupScrolling\n")
+        # if hasattr(self, 'SetupScrolling'):
+        #     self.SetupScrolling(scrollToTop=True, scrollIntoView=True)
+        #     # self.ShowScrollbars(wx.SHOW_SB_ALWAYS, wx.SHOW_SB_ALWAYS)
+        #     print("DEBUG: KwEditor init at SELF SetupScrolling\n")
         # self.Refresh()
         PUBLISHER.subscribe(self._before_saving, RideBeforeSaving)
         PUBLISHER.subscribe(self._data_changed, RideItemStepsChanged)
@@ -698,7 +700,7 @@ def _execute_clipboard_command(self, command_class):
                     data = self._get_main_data(data)
                 self._execute(command_class(self.selection.topleft, data))
 
-    def _get_main_data(self, data: []) -> []:
+    def _get_main_data(self, data: Iterable) -> list:
         main_data = []
         for ldata in data:
             new_data = []

src/robotide/version.py

@@ -15,4 +15,4 @@
 #
 # Automatically generated by `tasks.py`.
 
-VERSION = 'v2.2dev28'
+VERSION = 'v2.2dev29'