Initial settings edit button on Preferences. Make backup of settings.cfg

Author: HelioGuilherme66

src/robotide/application/application.py

@@ -20,8 +20,6 @@
 from contextlib import contextmanager
 from pathlib import Path
 
-from pygments.styles.dracula import background
-
 from ..namespace import Namespace
 from ..controller import Project
 from ..spec import librarydatabase

src/robotide/preferences/__init__.py

@@ -49,6 +49,8 @@ def __init__(self, settings):
         self.settings = settings
         self._preference_panels = []
         self._add_builtin_preferences()
+        self.settings_path = self.settings._default_path
+        print(f"DEBUG: preferences/__init__.py Preferences settings_path={self.settings_path}")
 
     @property
     def preference_panels(self):

src/robotide/preferences/editor.py

@@ -36,6 +36,7 @@
 from wx.lib.scrolledpanel import ScrolledPanel
 
 from .settings import RideSettings
+from ..widgets import ButtonWithHandler, HorizontalSizer
 
 _ = wx.GetTranslation  # To keep linter/code analyser happy
 builtins.__dict__['_'] = wx.GetTranslation
@@ -198,16 +199,28 @@ class PanelContainer(wx.Panel):
     Each page has a title area, and an area for a preferences panel
     """
     def __init__(self, *args, **kwargs):
+        from ..editor import customsourceeditor
         super(PanelContainer, self).__init__(*args, **kwargs)
 
         self._current_panel = None
         self._settings = RideSettings()
         self.settings = self._settings['General']
         self.title = wx.StaticText(self, label="Your message here")
+        print(f"DEBUG: preferences/editor.py PanelContainer settings_path={self._settings.user_path}")
+        hsizer = HorizontalSizer()
+        config_button = ButtonWithHandler(self, _('Settings'), bitmap='wrench_orange.png',
+                                          fsize=self.settings[FONT_SIZE],
+                                          handler=lambda e: customsourceeditor.main(self._settings.user_path))
+        config_button.SetBackgroundColour(self.settings['background'])
+        config_button.SetOwnBackgroundColour(self.settings['background'])
+        config_button.SetForegroundColour(self.settings['foreground'])
+        hsizer.Add(self.title, 0, wx.TOP | wx.LEFT | wx.EXPAND, 10)
+        hsizer.add_expanding(config_button, 1, 10)
         self.panels_container = ScrolledPanel(self, wx.ID_ANY, style=wx.TAB_TRAVERSAL)
         self.panels_container.SetupScrolling()
         sizer = wx.BoxSizer(wx.VERTICAL)
-        sizer.Add(self.title, 0, wx.TOP | wx.LEFT | wx.EXPAND, 4)
+        sizer.Add(hsizer)
+        # sizer.Add(self.title, 0, wx.TOP | wx.LEFT | wx.EXPAND, 4)
         sizer.Add(wx.StaticLine(self), 0, wx.EXPAND | wx.TOP | wx.BOTTOM, 4)
         sizer.Add(self.panels_container, 1, wx.EXPAND)
         self.SetSizer(sizer)

src/robotide/preferences/general.py

@@ -86,6 +86,7 @@ def __init__(self, settings, *args, **kwargs):
         # don't have the time to do that right now, so this will have
         # to suffice.
 
+        # print(f"DEBUG: preferences/general.py GeneralPeferences settings_path={self._settings._default_path}")
         ui_language = self._select_ui_language()
         font_editor = self._create_font_editor()
         colors_sizer = self.create_colors_sizer()

src/robotide/preferences/settings.py

@@ -49,6 +49,8 @@ def _copy_or_migrate_user_settings(settings_dir, source_path, dest_file_name):
     m_error = None
     if not os.path.exists(source_path):
         raise(FileNotFoundError(source_path))
+    else:
+        shutil.copyfile(source_path, source_path + '._backup')
     if not dest_file_name:
         dest_file_name = os.path.basename(source_path)
     settings_path = os.path.join(settings_dir, dest_file_name)
@@ -60,12 +62,12 @@ def _copy_or_migrate_user_settings(settings_dir, source_path, dest_file_name):
             SettingsMigrator(source_path, settings_path).migrate()
             # print(f"DEBUG: settings After migration {source_path} with {settings_path}")
         except ConfigObjError as parsing_error:
-            print("WARNING! corrupted configuration file replaced with defaults")
+            print("WARNING! corrupted configuration file replaced with defaults\n"
+                  f"A backup of the settings is at: {source_path + '._backup'}")
             print(parsing_error)
             m_error = parsing_error
             shutil.copyfile(settings_path, settings_path + '_old_broken')
-            print("(backed up corrupted configuration file at: %s)" %
-                  (settings_path + '_old_broken'))
+            print(f"(backed up corrupted configuration file at: {settings_path + '_old_broken'}")
             shutil.copyfile(source_path, settings_path)
             # print("DEBUG: source %s corrupted settings %s\n" % (source_path, settings_path))
         finally:  # DEBUG Try to merge some settings
@@ -362,22 +364,24 @@ def __init__(self, path=None):
             elif path.endswith('.cfg') and os.path.exists(path):
                 self._default_path = path
         # print(f"DEBUG: settings.py RideSettings SETTINGS {self._default_path=}")
-        user_path = initialize_settings(self._default_path)
-        Settings.__init__(self, user_path)
-        self._settings_dir = os.path.dirname(user_path)
+        self.user_path = initialize_settings(self._default_path)
+        Settings.__init__(self, self.user_path)
+        self._settings_dir = os.path.dirname(self.user_path)
         # print(f"DEBUG: RideSettings, self._settings_dir={self._settings_dir}")
         self.get('install root', os.path.dirname(os.path.dirname(__file__)))
         self.executable = self.get('executable', EXECUTABLE)
         if self.executable != EXECUTABLE:
             digest = 0
             for c in EXECUTABLE:
                 digest += ord(c)
-            new_user_path = user_path.replace("settings.cfg", f"settings_{digest}.cfg")
-            new_user_path = initialize_settings(user_path, new_user_path)
+            new_user_path = self.user_path.replace("settings.cfg", f"settings_{digest}.cfg")
+            new_user_path = initialize_settings(self.user_path, new_user_path)
+            self.user_path = new_user_path
             Settings.__init__(self, new_user_path)
             self._settings_dir = os.path.dirname(new_user_path)
             self.set('install root', os.path.dirname(os.path.dirname(__file__)))
-            self.executable = self.set('executable', EXECUTABLE)
+            self.set('executable', EXECUTABLE)
+            self.set('last_settings_path', self.user_path)
 
     def get_path(self, *parts):
         """Returns path which combines settings directory and given parts."""