Fixes not clearing fixtures, and synchronizing in Text Editor (#2567)

Author: HelioGuilherme66

CHANGELOG.adoc

@@ -10,6 +10,8 @@ and this project adheres to http://semver.org/spec/v2.0.0.html[Semantic Versioni
 
 == Fixed
 
+-- Fixed clearing or emptying fixtures (Setups, Teardowns), now removes headers and synchronizes Text Editor
+
 -- Fixed selection and persistance of colors in File Explorer and Project Tree panels
 
 -- Fixed not using defined color for help and HTML content

src/robotide/controller/settingcontrollers.py

@@ -104,6 +104,7 @@ def notify_value_changed(self):
     def clear(self):
         self._data.reset()
         self.mark_dirty()
+        RideItemSettingsChanged(item=self._parent).publish()
 
     def _changed(self, value):
         return value != self._data.value

src/robotide/editor/settingeditors.py

@@ -133,8 +133,13 @@ def OnEdit(self, event=None):
         self._editing = True
         dlg = self._create_editor_dialog()
         if dlg.ShowModal() == wx.ID_OK:
-            self._set_value(dlg.get_value(), dlg.get_comment())
-            self._update_and_notify()
+            value = dlg.get_value()
+            comment = dlg.get_comment()
+            if value != ['']:
+                self._set_value(value, comment)
+                self._update_and_notify()
+            else:
+                wx.CallAfter(self.OnClear, event)
         dlg.Destroy()
         self._editing = False
 

src/robotide/version.py

@@ -14,5 +14,5 @@
 #  limitations under the License.
 #
 # Automatically generated by `tasks.py`.
-VERSION = '2.0.1.dev2'
+VERSION = '2.0.1.dev3'
 

utest/controller/test_controllers.py

@@ -31,7 +31,8 @@
     WithListOperations)
 from robotide.publish.messages import (
     RideImportSetting, RideImportSettingRemoved, RideImportSettingAdded,
-    RideImportSettingChanged)
+    RideImportSettingChanged, RideItemSettingsChanged)
+from robotide.publish import PUBLISHER
 from robotide.controller.tags import Tag
 
 from utest.resources.mocks import PublisherListener
@@ -131,6 +132,17 @@ def setUp(self):
         self.fix.args = ['argh', 'urgh']
         self.parent = _FakeParent()
         self.ctrl = FixtureController(self.parent, self.fix)
+        self._reset_changes()
+        PUBLISHER.subscribe(self._change_detection, RideItemSettingsChanged)
+
+    def tearDown(self):
+        PUBLISHER.unsubscribe(self._change_detection, RideItemSettingsChanged)
+
+    def _reset_changes(self):
+        self._changed = None
+
+    def _change_detection(self, message):
+        self._changed = message
 
     def test_creation(self):
         assert self.ctrl.display_value == 'My Setup | argh | urgh'
@@ -178,6 +190,18 @@ def test_contains_keyword_with_regexp_with_empty_fixture(self):
         keyword_regexp = re.compile(r'foo.*bar')
         assert not empty_fixture_controller.contains_keyword(keyword_regexp)
 
+    def test_setting_value_triggers_change_message(self):
+        self.ctrl.set_value('No Operation')
+        assert self._changed is not None
+
+    def test_setting_empty_value_triggers_change_message(self):
+        self.ctrl.set_value('')
+        assert self._changed is not None
+
+    def test_clearing_setting_value_triggers_change_message(self):
+        self.ctrl.clear()
+        assert self._changed is not None
+
 
 class TagsControllerTest(unittest.TestCase):
 

utest/resources/fake.cfg

@@ -1,6 +1,4 @@
 
 auto imports = []
 pythonpath = []
-excludes = None
-txt number of spaces = 2
 [Plugins]