Skip to content

Commit 23a4c2c

Browse files
authored
Moved one Wait For Condition keyword test to own test (#996)
Is the seems that Firefox has regression but and executing complex JavaScript does not work correctly. Moving it to own test and marking the test to Known Issue Firefox tag. Also refactored run_tests.py to set regression and inprogress tags
1 parent c41f797 commit 23a4c2c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

test/acceptance/keywords/waiting.robot

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,14 @@ Force Tags Known Issue Internet Explorer
77
Wait For Condition
88
Title Should Be Original
99
Wait For Condition return window.document.title == "Changed"
10-
Wait For Condition style = document.querySelector('#content').style; return style.background == "red" && style.color == "white"
1110
Run Keyword And Expect Error
1211
... Condition 'return window.document.title == "Invalid"' did not become true in 100 milliseconds.
1312
... Wait For Condition return window.document.title == "Invalid" ${0.1}
1413

14+
Wait For Condition Comlext Wait
15+
[Tags] Known Issue Firefox
16+
Wait For Condition style = document.querySelector('#content').style; return style.background == 'red' && style.color == 'white'
17+
1518
Wait For Condition requires `return`
1619
Run Keyword And Expect Error
1720
... ValueError: Condition 'window.document.title == "Changed"' did not have mandatory 'return'.

test/run_tests.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@
7676
]
7777
REBOT_OPTIONS = [
7878
'--outputdir', RESULTS_DIR,
79-
'--critical', 'regression',
80-
'--noncritical', 'inprogress',
8179
'--noncritical', 'known issue {browser}',
8280
]
8381

0 commit comments

Comments
 (0)