Removes support for passing attribute in locator for Get Element Attribute kw (#1190)

* Removes support for passing attribute in locator for Get Element Attribute kw

* Remove not needed unit test

Author: aaltat

atest/acceptance/keywords/elements.robot

@@ -40,22 +40,19 @@ Assign Id To Element
     Page Should Not Contain Element    my id
 
 Get Element Attribute
-    ${id}=    Get Element Attribute    link=Link with id@id
+    ${id}=    Get Element Attribute    link:Link with id    id
     Should Be Equal    ${id}    some_id
-    ${id}=    Get Element Attribute    dom=document.getElementsByTagName('a')[3]@id
+    ${id}=    Get Element Attribute    dom:document.getElementsByTagName('a')[3]    id
     Should Be Equal    ${id}    some_id
-    ${class}=    Get Element Attribute    second_div@class
+    ${class}=    Get Element Attribute    second_div    class
     Should Be Equal    ${class}    Second Class
     ${id}=    Get Element Attribute    link=Link with id    id
     Should Be Equal    ${id}    some_id
-    ${element_by_dom}=    Get Webelement    dom=document.getElementsByTagName('a')[3]
-    ${id}=    Get Element Attribute    ${element_by_dom}    id
-    Should Be Equal    ${id}    some_id
     ${second_div}=    Get Webelement    second_div
     ${class}=    Get Element Attribute    ${second_div}    class
     Should Be Equal    ${class}    Second Class
 
-Get Element Attribute Value Should Be Should Be Succesfull 
+Get Element Attribute Value Should Be Should Be Succesfull
     Element Attribute Value Should Be  link=Absolute external link  href  http://www.google.com/
 
 Get Element Attribute And Element Attribute Value Should Be Should have same results

src/SeleniumLibrary/keywords/element.py

@@ -364,7 +364,7 @@ def element_text_should_not_be(self, locator, not_expected, message=None, ignore
             raise AssertionError(message)
 
     @keyword
-    def get_element_attribute(self, locator, attribute=None):
+    def get_element_attribute(self, locator, attribute):
         """Returns value of ``attribute`` from element ``locator``.
 
         See the `Locating elements` section for details about the locator
@@ -373,14 +373,10 @@ def get_element_attribute(self, locator, attribute=None):
         Example:
         | ${id}= | `Get Element Attribute` | css:h1 | id |
 
-        Passing attribute name as part of the ``locator`` is deprecated
-        since SeleniumLibrary 3.0. The explicit ``attribute`` argument
+        Passing attribute name as part of the ``locator`` was removed
+        in SeleniumLibrary 3.2. The explicit ``attribute`` argument
         should be used instead.
         """
-        if is_noney(attribute):
-            self.warn("Using 'Get Element Attribute' without explicit "
-                      "attribute is deprecated.")
-            locator, attribute = locator.rsplit('@', 1)
         return self.find_element(locator).get_attribute(attribute)
 
     @keyword

utest/test/keywords/test_keyword_arguments_element.py

@@ -35,20 +35,6 @@ def test_element_text_should_be(self):
         with self.assertRaisesRegexp(AssertionError, 'foobar'):
             self.element.element_text_should_be(locator, 'not text', 'foobar')
 
-    def test_get_element_attribute(self):
-        locator = '//div'
-        attrib = 'id'
-        element = mock()
-        when(self.element).find_element(locator).thenReturn(element)
-        when(element).get_attribute(attrib).thenReturn('value')
-        value = self.element.get_element_attribute(locator, attrib)
-        self.assertEqual(value, 'value')
-
-        when(logger).warn("Using 'Get Element Attribute' without explicit "
-                          "attribute is deprecated.", False).thenReturn(None)
-        value = self.element.get_element_attribute('//div@id', 'None')
-        self.assertEqual(value, 'value')
-
     def test_get_matching_xpath_count(self):
         locator = '//div'
         when(self.element).find_elements('xpath:' + locator).thenReturn([])