Fixes suggested by pekka

Author: zephraph

src/Selenium2Library/keywords/_element.py

@@ -479,29 +479,23 @@ def simulate(self, locator, event):
     def press_key(self, locator, key):
         """Simulates user pressing key on element identified by `locator`.
 
-        `key` is either a single character, a numerical ASCII code of the key,\
+        `key` is either a single character, a numerical ASCII code of the key lead by '\\\\',
          or a NAMED KEY as described at https://selenium.googlecode.com/git/docs/api/py/webdriver/selenium.webdriver.common.keys.html
 
         Examples:
-        | Press Key | text_field   | q        |                                               |
-        | Press Key | login_button | \\\\13   | # ASCII code for Enter key (DEPRECATED)       |
-        | Press Key | login_button | 10       | # ASCII code for Return key                   |
+        | Press Key | text_field   | q        | # The letter 'q'                              |
+        | Press Key | login_button | \\\\13   | # ASCII code for Enter key                    |
         | Press Key | nav_console  | ARROW_UP | # selenium.webdriver.common.keys ARROW_UP KEY |
-        
+
         NAMED KEY value is new in Selenium2Library 1.7.3.
         """
         if len(key) > 1:
             if key.startswith('\\'):
-                self._warn("Press Key: Escaped ASCII codes are deprecated. Use plain numeric value: '%s'" % (key[1:]))
                 key = self._map_ascii_key_code_to_key(int(key[1:]))
             else:
-                try:
-                    key = (key.isdecimal() and self._map_ascii_key_code_to_key(int(key))) or\
-                          ((not key.isdecimal()) and self._map_named_key_code_to_special_key(key))
-                except:
-                    raise ValueError("Key value '%s' is invalid." % (key))
+                key = self._map_named_key_code_to_special_key(key)
         element = self._element_find(locator, True, True)
-        #select it
+        # select it
         element.send_keys(key)
 
     # Public, links
@@ -609,7 +603,7 @@ def get_matching_xpath_count(self, xpath):
         """Returns number of elements matching `xpath`
 
         One should not use the xpath= prefix for 'xpath'. XPath is assumed.
-        
+
         Correct:
         | count = | Get Matching Xpath Count | //div[@id='sales-pop']
         Incorrect:
@@ -625,7 +619,7 @@ def xpath_should_match_x_times(self, xpath, expected_xpath_count, message='', lo
         """Verifies that the page contains the given number of elements located by the given `xpath`.
 
         One should not use the xpath= prefix for 'xpath'. XPath is assumed.
-        
+
         Correct:
         | Xpath Should Match X Times | //div[@id='sales-pop'] | 1
         Incorrect:
@@ -761,7 +755,7 @@ def _map_ascii_key_code_to_key(self, key_code):
     def _map_named_key_code_to_special_key(self, key_name):
         try:
            return getattr(Keys, key_name)
-        except:
+        except AttributeError:
            message = "Unknown key named '%s'." % (key_name)
            self._debug(message)
            raise ValueError(message)

test/acceptance/keywords/textfields.robot

@@ -11,7 +11,7 @@ Get Value From Text Field
     Clear Element Text    name
     ${text} =    Get Value    name
     Should Be Equal    ${text}    ${EMPTY}
-  
+
 
 Input Unicode In Text Field
     Input Text    name    ${unic_text}
@@ -38,13 +38,13 @@ Press Key
     Press Key    username_field    DELETE
     Press Key    username_field    ARROW_LEFT
     Press Key    username_field    ARROW_RIGHT
-    Press Key    username_field    \\108    #This is the 'l' char (deprecated style)
-    Press Key    username_field    111    #This is the 'o' char
+    Press Key    username_field    \\108    #This is the 'l' char
+    Press Key    username_field    o
     ${text} =    Get Value    username_field
     Should Be Equal    ${text}    James Blond
     Press Key    password_field    f
     Press Key    password_field    9
-    Press Key    login_button    10
+    Press Key    login_button    ENTER
     Verify Location Is "forms/submit.html"
 
 Attempt Clear Element Text On Non-Editable Field