Merge pull request #258 from ombre42/master

fixes #217 - copy desired capabilities before modifying

Author: emanlove

src/Selenium2Library/keywords/_browsermanagement.py

@@ -550,7 +550,7 @@ def _create_remote_web_driver(self , capabilities_type , remote_url , desired_ca
         '''parses the string based desired_capabilities if neccessary and
         creates the associated remote web driver'''
 
-        desired_capabilities_object = capabilities_type
+        desired_capabilities_object = capabilities_type.copy()
 
         if type(desired_capabilities) in (str, unicode):
             desired_capabilities = self._parse_capabilities_string(desired_capabilities)

test/unit/keywords/test_browsermanagement.py

@@ -70,6 +70,12 @@ def test_create_remote_browser_with_string_desired_prefs(self):
         self.verify_browser(webdriver.Remote, "chrome", remote="http://127.0.0.1/wd/hub",
             desired_capabilities=expected_caps)
 
+    def test_capabilities_attribute_not_modified(self):
+        expected_caps = {"some_cap":"42"}
+        self.verify_browser(webdriver.Remote, "chrome", remote="http://127.0.0.1/wd/hub",
+            desired_capabilities=expected_caps)
+        self.assertFalse("some_cap" in webdriver.DesiredCapabilities.CHROME)
+
     def test_set_selenium_timeout_only_affects_open_browsers(self):
         bm = _BrowserManagementKeywords()
         first_browser, second_browser = mock(), mock()