Improve implcit wait testing (#1360)

Fixes #1362

Author: aaltat

atest/acceptance/keywords/implicit_wait.robot

@@ -0,0 +1,34 @@
+*** Settings ***
+Resource          ../resource.robot
+
+*** Test Cases ***
+Browser Open With Implicit Wait And Test Wating
+    [Setup]    Open Browser To Start Page
+    ${old_value} =     Set Selenium Implicit Wait    3
+    ${start_time} =    Get Current Date    result_format=epoch    exclude_millis=yes
+    Run Keyword And Ignore Error  Wait Until Page Contains Element       //not_here    1
+    ${end_time} =      Get Current Date    result_format=epoch    exclude_millis=yes
+    Should Be True     ${start_time + 3} <= ${end_time}
+    [Teardown]    Set Selenium Implicit Wait    ${old_value}
+
+
+Implicit Wait And New Window
+    ${old_value} =     Set Selenium Implicit Wait    3
+    Execute Javascript    window.open("about:blank")
+    Select Window      NEW
+    ${start_time} =    Get Current Date    result_format=epoch    exclude_millis=yes
+    Run Keyword And Ignore Error  Wait Until Page Contains Element       //not_here    1
+    ${end_time} =      Get Current Date    result_format=epoch    exclude_millis=yes
+    Should Be True     ${start_time + 3} <= ${end_time}
+    [Teardown]    Set Selenium Implicit Wait    ${old_value}
+
+Implicit Wait And Back To Main Window
+    ${old_value} =     Set Selenium Implicit Wait    3
+    Execute Javascript    window.open("about:blank")
+    Select Window      NEW
+    Select Window      MAIN
+    ${start_time} =    Get Current Date    result_format=epoch    exclude_millis=yes
+    Run Keyword And Ignore Error  Wait Until Page Contains Element       //not_here    1
+    ${end_time} =      Get Current Date    result_format=epoch    exclude_millis=yes
+    Should Be True     ${start_time + 3} <= ${end_time}
+    [Teardown]    Set Selenium Implicit Wait    ${old_value}

atest/acceptance/open_and_close.robot

@@ -7,10 +7,6 @@ Browser Should Open And Close
     Open Browser To Start Page Without Testing Default Options
     Close Browser
 
-Browser Open With Implicit Wait Should Not Override Default
-    Open Browser To Start Page And Test Implicit Wait    10
-    Close Browser
-
 There Should Be A Good Error Message If Browser Is Not Opened
     Run Keyword And Expect Error    No browser is open.    Title Should Be    foo
 

atest/acceptance/resource.robot

@@ -31,20 +31,6 @@ Open Browser To Start Page Without Testing Default Options
     ${orig timeout} =    Set Selenium Timeout    10 seconds
     [Return]    ${orig speed}    5 seconds
 
-Open Browser To Start Page And Test Implicit Wait
-    [Arguments]    ${implicit_wait}
-    [Documentation]    This keyword tests that 'Set Selenium Implicit Wait' and
-    ...    'Get Selenium Implicit Wait' work as expected
-    Should Not Be Equal    0    ${implicit_wait}
-    ...    Please do not pass in a value of 0 for the implicit wait argument for this function
-    ${old_wait}=    Set Selenium Implicit Wait    ${implicit_wait}
-    Open Browser    ${FRONT PAGE}    ${BROWSER}    remote_url=${REMOTE_URL}
-    ...    desired_capabilities=${DESIRED_CAPABILITIES}
-    ${default_implicit_wait} =    Get Selenium Implicit Wait
-    Should Be Equal    ${implicit_wait} seconds    ${default_implicit_wait}
-    #be sure to revert the implicit wait to whatever it was before so as to not effect other tests
-    Set Selenium Implicit Wait    ${old_wait}
-
 Cannot Be Executed In IE
     [Documentation]    Cannot Be Executed In IE
     ${runsInIE}=    Set Variable If    "${BROWSER}".replace(' ', '').lower() in ['ie', '*iexplore', 'internetexplorer']    ${TRUE}

utest/test/keywords/test_browsermanagement.py

@@ -4,7 +4,7 @@
 from selenium import webdriver
 
 from SeleniumLibrary.keywords import BrowserManagementKeywords
-from SeleniumLibrary.utils import SELENIUM_VERSION
+from SeleniumLibrary import SeleniumLibrary
 
 
 class BrowserManagementTests(unittest.TestCase):
@@ -26,6 +26,33 @@ def test_set_selenium_timeout_only_affects_open_browsers(self):
         verifyNoMoreInteractions(second_browser)
         unstub()
 
+    def test_selenium_implicit_wait_default(self):
+        sl = SeleniumLibrary()
+        self.assertEqual(sl.implicit_wait, 0.0)
+
+    def test_set_selenium_implicit_wait(self):
+        sl = SeleniumLibrary()
+        sl.set_selenium_implicit_wait('5.0')
+        self.assertEqual(sl.implicit_wait, 5.0)
+
+        sl.set_selenium_implicit_wait('1 min')
+        self.assertEqual(sl.implicit_wait, 60.0)
+
+    def test_selenium_implicit_wait_error(self):
+        with self.assertRaises(ValueError):
+            SeleniumLibrary(implicit_wait='False')
+        sl = SeleniumLibrary(implicit_wait='3')
+        with self.assertRaises(ValueError):
+            sl.set_selenium_implicit_wait('1 vuosi')
+
+    def test_selenium_implicit_wait_get(self):
+        sl = SeleniumLibrary(implicit_wait='3')
+        self.assertEqual(sl.get_selenium_implicit_wait(), '3 seconds')
+
+        org_value = sl.set_selenium_implicit_wait('1 min')
+        self.assertEqual(sl.get_selenium_implicit_wait(), '1 minute')
+        self.assertEqual(org_value, '3 seconds')
+
     def test_bad_browser_name(self):
         ctx = mock()
         bm = BrowserManagementKeywords(ctx)