Fixed service_log_path with for Firefox (#1392)

Fixes #1333

Author: aaltat

src/SeleniumLibrary/keywords/webdrivertools.py

@@ -60,7 +60,7 @@ def create_driver(self, browser, desired_capabilities, remote_url,
         if (creation_method == self.create_firefox
                 or creation_method == self.create_headless_firefox):
             return creation_method(desired_capabilities, remote_url,
-                                   profile_dir, service_log_path)
+                                   profile_dir, service_log_path=service_log_path)
         return creation_method(desired_capabilities, remote_url, service_log_path=service_log_path)
 
     def _get_creator_method(self, browser):

utest/test/keywords/test_webdrivercreator_service_log_path.py

@@ -95,6 +95,19 @@ def test_create_headlessfirefox_with_service_log_path_real_path(self):
         driver = self.creator.create_headless_firefox({}, None, ff_profile_dir=None, service_log_path=log_file)
         self.assertEqual(driver, expected_webdriver)
 
+    def test_create_firefox_from_create_driver(self):
+        log_file = os.path.join(self.output_dir, 'firefox-1.log')
+        expected_webdriver = mock()
+        profile = mock()
+        when(webdriver).FirefoxProfile().thenReturn(profile)
+        options = mock()
+        when(webdriver).FirefoxOptions().thenReturn(options)
+        when(webdriver).Firefox(options=None, firefox_profile=profile,
+                                service_log_path=log_file).thenReturn(expected_webdriver)
+        driver = self.creator.create_driver('firefox ', {}, remote_url=None,  profile_dir=None,
+                                            service_log_path=log_file)
+        self.assertEqual(driver, expected_webdriver)
+
     def test_create_ie_with_service_log_path_real_path(self):
         log_file = os.path.join(self.output_dir, 'ie-1.log')
         expected_webdriver = mock()